Issue 240113004: Rename IDS ids to be more consistent in ui_strings.grd.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 240113004: Rename IDS ids to be more consistent in ui_strings.grd. (Closed)

Created:
6 years, 8 months ago by Thiemo Nagel

Modified:
6 years, 8 months ago

Reviewers:
bartfab (slow), tony

CC:
chromium-reviews, jshin+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@GetProfileByUser-rename

Visibility:
Public.

Rename IDS ids to be more consistent in ui_strings.grd. This fixes the awkward sorting in grit_whitelist.txt and had been suggested by Bartosz some time ago. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264312

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+88 lines, -88 lines)			Patch
M	build/ios/grit_whitelist.txt	View	1 chunk	+22 lines, -22 lines	0 comments	Download
M	ui/base/l10n/formatter.cc	View	4 chunks	+22 lines, -22 lines	0 comments	Download
M	ui/base/strings/ui_strings.grd	View	22 chunks	+44 lines, -44 lines	0 comments	Download

Total messages: 7 (0 generated)

Thiemo Nagel

Hi Tony and Bartosz, could you please take a look at this cosmetic improvement? Thank ...

6 years, 8 months ago (2014-04-16 12:36:00 UTC) #1

Thiemo Nagel

On 2014/04/16 18:31:53, tony wrote: > lgtm Thank you!

6 years, 8 months ago (2014-04-16 19:58:08 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tnagel@chromium.org/240113004/1

6 years, 8 months ago (2014-04-16 19:58:50 UTC) #6

Message was sent while issue was closed.

Change committed as 264312