Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 2401073002: MD Settings: Site settings, remove unwanted margin before dropdown. (Closed)

Created:
4 years, 2 months ago by dpapad
Modified:
4 years, 2 months ago
Reviewers:
dschuyler
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Site settings, remove unwanted margin before dropdown. BUG=653405 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/29f05dad8b55b1b31d6835a9cd970718e20c47e4 Cr-Commit-Position: refs/heads/master@{#423982}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/browser/resources/settings/settings_shared_css.html View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
dpapad
The CSS rule was a left-over from a long time ago when the a11y page ...
4 years, 2 months ago (2016-10-07 17:32:05 UTC) #3
dschuyler
lgtm
4 years, 2 months ago (2016-10-07 19:05:49 UTC) #4
dpapad
On 2016/10/07 at 19:05:49, dschuyler wrote: > lgtm Thanks. I forgot to link to the ...
4 years, 2 months ago (2016-10-07 19:16:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401073002/1
4 years, 2 months ago (2016-10-07 19:17:42 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/294347)
4 years, 2 months ago (2016-10-07 21:11:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401073002/1
4 years, 2 months ago (2016-10-07 21:24:40 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 22:17:29 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 22:20:30 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29f05dad8b55b1b31d6835a9cd970718e20c47e4
Cr-Commit-Position: refs/heads/master@{#423982}

Powered by Google App Engine
This is Rietveld 408576698