MD Settings: Align rows underneath settings-checkboxes with the settings-checkbox labels

MD Settings: Align rows underneath settings-checkboxes with the settings-checkbox labels

This lets us match the mocks without introducing much overhead into the HTML.

Before/after screenshots: http://imgur.com/a/msDoQ

BUG=556643
Committed: https://crrev.com/b08b8671e8a4cbbc5c88a2d16e4be9f952acf2f7
Cr-Commit-Position: refs/heads/master@{#378876}

[michaelpg, 2016-03-02 21:51:32]

Description was changed from

==========
MD Settings: Align rows underneath settings-checkboxes with the
settings-checkbox labels

This lets us match the mocks without introducing much overhead into the HTML.

BUG=556643
==========

to

==========
MD Settings: Align rows underneath settings-checkboxes with the
settings-checkbox labels

This lets us match the mocks without introducing much overhead into the HTML.

Before/after screenshots: http://imgur.com/a/msDoQ

BUG=556643
==========

[michaelpg, 2016-03-02 21:53:05]

michaelpg@chromium.org changed reviewers:
+ dbeam@chromium.org, dschuyler@chromium.org

[michaelpg, 2016-03-02 21:53:05]

michaelpg@chromium.org changed required reviewers:
+ dschuyler@chromium.org

[michaelpg, 2016-03-02 21:53:06]

PTAL. I'll use this on the work-in-progress Keyboard page too.

dbeam: see usage of calc(), is this a hack or just brilliant?

https://codereview.chromium.org/1758923002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_shared_css.html (right):

https://codereview.chromium.org/1758923002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_shared_css.html:249:
-webkit-margin-start: calc(
This, um, apparently works, both in native CSS in Chrome and in Polymer's
polyfill.

[Dan Beam, 2016-03-02 22:04:32]

lgtm but can haz screenshot?

https://codereview.chromium.org/1758923002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/settings_shared_css.html (right):

https://codereview.chromium.org/1758923002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/settings_shared_css.html:249:
-webkit-margin-start: calc(
On 2016/03/02 21:53:06, michaelpg wrote:
> This, um, apparently works, both in native CSS in Chrome and in Polymer's
> polyfill.

yeah, i did something like this in downloads (but not sure i committed it)

kinda magical

[dschuyler, 2016-03-02 22:16:49]

lgtm

[michaelpg, 2016-03-02 22:23:59]

On 2016/03/02 22:04:32, Dan Beam wrote:
> lgtm but can haz screenshot?

read the description

> 
>
https://codereview.chromium.org/1758923002/diff/1/chrome/browser/resources/se...
> File chrome/browser/resources/settings/settings_shared_css.html (right):
> 
>
https://codereview.chromium.org/1758923002/diff/1/chrome/browser/resources/se...
> chrome/browser/resources/settings/settings_shared_css.html:249:
> -webkit-margin-start: calc(
> On 2016/03/02 21:53:06, michaelpg wrote:
> > This, um, apparently works, both in native CSS in Chrome and in Polymer's
> > polyfill.
> 
> yeah, i did something like this in downloads (but not sure i committed it)
> 
> kinda magical

[Dan Beam, 2016-03-02 22:34:06]

On 2016/03/02 22:23:59, michaelpg wrote:
> On 2016/03/02 22:04:32, Dan Beam wrote:
> > lgtm but can haz screenshot?
> 
> read the description

sweet, thx

[michaelpg, 2016-03-02 22:35:28]

The CQ bit was checked by michaelpg@chromium.org

[commit-bot: I haz the power, 2016-03-02 22:36:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1758923002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1758923002/1

[commit-bot: I haz the power, 2016-03-02 23:25:55]

Description was changed from

==========
MD Settings: Align rows underneath settings-checkboxes with the
settings-checkbox labels

This lets us match the mocks without introducing much overhead into the HTML.

Before/after screenshots: http://imgur.com/a/msDoQ

BUG=556643
==========

to

==========
MD Settings: Align rows underneath settings-checkboxes with the
settings-checkbox labels

This lets us match the mocks without introducing much overhead into the HTML.

Before/after screenshots: http://imgur.com/a/msDoQ

BUG=556643
==========

[commit-bot: I haz the power, 2016-03-02 23:25:56]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-02 23:27:29]

Description was changed from

==========
MD Settings: Align rows underneath settings-checkboxes with the
settings-checkbox labels

This lets us match the mocks without introducing much overhead into the HTML.

Before/after screenshots: http://imgur.com/a/msDoQ

BUG=556643
==========

to

==========
MD Settings: Align rows underneath settings-checkboxes with the
settings-checkbox labels

This lets us match the mocks without introducing much overhead into the HTML.

Before/after screenshots: http://imgur.com/a/msDoQ

BUG=556643

Committed: https://crrev.com/b08b8671e8a4cbbc5c88a2d16e4be9f952acf2f7
Cr-Commit-Position: refs/heads/master@{#378876}
==========

[commit-bot: I haz the power, 2016-03-02 23:27:30]

Patchset 1 (id:??) landed as
https://crrev.com/b08b8671e8a4cbbc5c88a2d16e4be9f952acf2f7
Cr-Commit-Position: refs/heads/master@{#378876}