Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2401053002: Revert of Update systrace and profile_chrome's default agent behavior (Closed)

Created:
4 years, 2 months ago by Zhen Wang
Modified:
4 years, 2 months ago
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of Update systrace and profile_chrome's default agent behavior (patchset #1 id:1 of https://codereview.chromium.org/2391383004/ ) Reason for revert: Causing Chrome Perf bot to fail. BUG=653898 Original issue's description: > Update systrace and profile_chrome's default agent behavior > > Systrace needs to have atrace as the default agent. > profile_chrome needs to have Chrome tracing as the default agent. > > BUG=catapult:#2912,catapult:#2781 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f7d080135d034437b8ce00208db09b28796490f3 TBR=ccraik@google.com,peter.y.washington@gmail.com,skyostil@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=catapult:#2912,catapult:#2781 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/186f6b0164710aa9a37038a6f88b3665950887ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -14 lines) Patch
M systrace/profile_chrome/chrome_tracing_agent.py View 2 chunks +3 lines, -2 lines 0 comments Download
M systrace/profile_chrome/main.py View 1 chunk +0 lines, -4 lines 0 comments Download
M systrace/systrace/run_systrace.py View 1 chunk +0 lines, -4 lines 0 comments Download
M systrace/systrace/tracing_agents/atrace_agent.py View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Zhen Wang
Created Revert of Update systrace and profile_chrome's default agent behavior
4 years, 2 months ago (2016-10-07 15:13:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2401053002/1
4 years, 2 months ago (2016-10-07 15:14:01 UTC) #3
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 15:14:09 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698