Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Unified Diff: chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

Issue 2401003002: Disabling NavigatingExtensionPopupBrowserTest.DownloadViaPost on (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
diff --git a/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc b/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
index 7b2e7dd11dd94f2ef42c9f379fe942b4461e2f41..f02bb13d2bc6e7160b3690990cbce4dd68a433e9 100644
--- a/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
+++ b/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc
@@ -991,7 +991,16 @@ IN_PROC_BROWSER_TEST_F(NavigatingExtensionPopupBrowserTest,
// GET should automagically start working for downloads.
// TODO(lukasza): https://crbug.com/650694: Add a "Get" flavour of the test once
// the download works both for GET and POST requests.
-IN_PROC_BROWSER_TEST_F(NavigatingExtensionPopupBrowserTest, DownloadViaPost) {
+
+// Disabled on Windows. See http://crbug.com/653856.
+#if defined(OS_WIN)
+#define MAYBE_DownloadViaPost DISABLED_DownloadViaPost
+#else
+#define MAYBE_DownloadViaPost DownloadViaPost
+#endif
+
+IN_PROC_BROWSER_TEST_F(NavigatingExtensionPopupBrowserTest,
+ MAYBE_DownloadViaPost) {
content::DownloadTestObserverTerminal downloads_observer(
content::BrowserContext::GetDownloadManager(browser()->profile()),
1, // == wait_count (only waiting for "download-test3.gif").
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698