Disabling NavigatingExtensionPopupBrowserTest.DownloadViaPost on

chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdint.h>
 
 #include "base/macros.h"
 #include "build/build_config.h"
 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
 #include "chrome/browser/extensions/browser_action_test_util.h"
@@ skipping 973 matching lines @@
 // works: No navigation, but download shelf visible + download goes through.
 //
 // Note - there is no "...ViaGet" flavour of this test, because we don't care
 // (yet) if GET succeeds with the download or not (it probably should succeed
 // for consistency with POST, but it always failed in M54 and before).  After
 // abandoing ShouldFork/OpenURL for all methods (not just for POST) [see comment
 // about https://crbug.com/646261 in ChromeContentRendererClient::ShouldFork]
 // GET should automagically start working for downloads.
 // TODO(lukasza): https://crbug.com/650694: Add a "Get" flavour of the test once
 // the download works both for GET and POST requests.
-IN_PROC_BROWSER_TEST_F(NavigatingExtensionPopupBrowserTest, DownloadViaPost) {
+
+// Disabled on Windows. See http://crbug.com/653856.
+#if defined(OS_WIN)
+#define MAYBE_DownloadViaPost DISABLED_DownloadViaPost
+#else
+#define MAYBE_DownloadViaPost DownloadViaPost
+#endif
+
+IN_PROC_BROWSER_TEST_F(NavigatingExtensionPopupBrowserTest,
+                       MAYBE_DownloadViaPost) {
   content::DownloadTestObserverTerminal downloads_observer(
       content::BrowserContext::GetDownloadManager(browser()->profile()),
       1,  // == wait_count (only waiting for "download-test3.gif").
       content::DownloadTestObserver::ON_DANGEROUS_DOWNLOAD_FAIL);
 
   // Navigate to a URL that replies with
   // Content-Disposition: attachment; filename=...
   // header.
   GURL download_url(
       embedded_test_server()->GetURL("foo.com", "/download-test3.gif"));
   TestPopupNavigationViaPost(download_url, EXPECTING_NAVIGATION_FAILURE);
 
   // Verify that "download-test3.gif got downloaded.
   downloads_observer.WaitForFinished();
   EXPECT_EQ(0u, downloads_observer.NumDangerousDownloadsSeen());
   EXPECT_EQ(1u, downloads_observer.NumDownloadsSeenInState(
                     content::DownloadItem::COMPLETE));
 
   // The test verification below is applicable only to scenarios where the
   // download shelf is supported - on ChromeOS, instead of the download shelf,
   // there is a download notification in the right-bottom corner of the screen.
 #if !defined(OS_CHROMEOS)
   EXPECT_TRUE(browser()->window()->IsDownloadShelfVisible());
 #endif
 }
 
 }  // namespace
 }  // namespace extensions