[compiler] Allow debug compilation for top-level eval.

[compiler] Allow debug compilation for top-level eval.

This removes the restriction of only allowing lazy compilation for
top-level eval code with a context. We can by now compile such code
without a concrete closure.

R=yangguo@chromium.org

Committed: https://crrev.com/891600068d0dafc899022bef993aa504fc6aa534
Cr-Commit-Position: refs/heads/master@{#40089}

[Michael Starzinger, 2016-10-07 09:49:42]

The CQ bit was checked by mstarzinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-07 09:49:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 10:23:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 10:23:19]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-10-07 11:06:41]

lgtm.

https://codereview.chromium.org/2400973002/diff/1/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/2400973002/diff/1/src/debug/debug.cc#newcode1460
src/debug/debug.cc:1460: // If not possible, comb the heap for the best suitable
compile target.
I think that we don't need this anymore. The whole point of this thing here is
to find a closure. Now that we don't need this anymore, we could just grab the
shared function info from the shared function info list on the script object.
Which we already do above.

I'll fix that in a separate CL.

[Michael Starzinger, 2016-10-07 13:38:42]

Thanks. Landing.

https://codereview.chromium.org/2400973002/diff/1/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/2400973002/diff/1/src/debug/debug.cc#newcode1460
src/debug/debug.cc:1460: // If not possible, comb the heap for the best suitable
compile target.
On 2016/10/07 11:06:41, Yang wrote:
> I think that we don't need this anymore. The whole point of this thing here is
> to find a closure. Now that we don't need this anymore, we could just grab the
> shared function info from the shared function info list on the script object.
> Which we already do above.
> 
> I'll fix that in a separate CL.

Acknowledged. Yeah, I was also wondering about further cleanup opportunities
here. Thanks!

[Michael Starzinger, 2016-10-07 13:39:00]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2016-10-07 13:39:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 13:42:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-07 13:42:53]

Description was changed from

==========
[compiler] Allow debug compilation for top-level eval.

This removes the restriction of only allowing lazy compilation for
top-level eval code with a context. We can by now compile such code
without a concrete closure.

R=yangguo@chromium.org
==========

to

==========
[compiler] Allow debug compilation for top-level eval.

This removes the restriction of only allowing lazy compilation for
top-level eval code with a context. We can by now compile such code
without a concrete closure.

R=yangguo@chromium.org

Committed: https://crrev.com/891600068d0dafc899022bef993aa504fc6aa534
Cr-Commit-Position: refs/heads/master@{#40089}
==========

[commit-bot: I haz the power, 2016-10-07 13:42:54]

Patchset 1 (id:??) landed as
https://crrev.com/891600068d0dafc899022bef993aa504fc6aa534
Cr-Commit-Position: refs/heads/master@{#40089}