[compiler] Allow debug compilation for top-level eval.

src/debug/debug.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/debug/debug.h"
 
 #include <memory>
 
 #include "src/api.h"
 #include "src/arguments.h"
@@ skipping 1433 matching lines @@
         // be no JSFunction referencing it. We can anticipate creating a debug
         // info while bypassing PrepareFunctionForBreakpoints.
         if (iteration > 1) {
           AllowHeapAllocation allow_before_return;
           CreateDebugInfo(shared_handle);
         }
         return shared_handle;
       }
     }
     // If not, compile to reveal inner functions, if possible.
-    if (shared->allows_lazy_compilation_without_context()) {
+    if (shared->allows_lazy_compilation()) {
       HandleScope scope(isolate_);
       if (!Compiler::CompileDebugCode(handle(shared))) break;
       continue;
     }
 
     // If not possible, comb the heap for the best suitable compile target.

[Yang, 2016/10/07 11:06:41]

I think that we don't need this anymore. The whole point of this thing here is
to find a closure. Now that we don't need this anymore, we could just grab the
shared function info from the shared function info list on the script object.
Which we already do above.

I'll fix that in a separate CL.

[Michael Starzinger, 2016/10/07 13:38:42]

Acknowledged. Yeah, I was also wondering about further cleanup opportunities
here. Thanks!

     JSFunction* closure;
     {
       HeapIterator it(isolate_->heap());
       SharedFunctionInfoFinder finder(position);
       while (HeapObject* object = it.next()) {
         JSFunction* candidate_closure = NULL;
         SharedFunctionInfo* candidate = NULL;
         if (object->IsJSFunction()) {
           candidate_closure = JSFunction::cast(object);
           candidate = candidate_closure->shared();
         } else if (object->IsSharedFunctionInfo()) {
           candidate = SharedFunctionInfo::cast(object);
-          if (!candidate->allows_lazy_compilation_without_context()) continue;
+          if (!candidate->allows_lazy_compilation()) continue;
         } else {
           continue;
         }
         if (candidate->script() == *script) {
           finder.NewCandidate(candidate, candidate_closure);
         }
       }
       closure = finder.ResultClosure();
       shared = finder.Result();
     }
@@ skipping 1074 matching lines @@
 }
 
 
 void LockingCommandMessageQueue::Clear() {
   base::LockGuard<base::Mutex> lock_guard(&mutex_);
   queue_.Clear();
 }
 
 }  // namespace internal
 }  // namespace v8