Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2400883003: RenderWidget::windowRect and viewRect should apply device emulation transform. (Closed)

Created:
4 years, 2 months ago by bokan
Modified:
4 years, 2 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

RenderWidget::windowRect and viewRect should apply device emulation transform. Since Blink's popup menus now rely on the RenderWidget keeping track of the view rect, the rect must return the emulated position of the popup. This is symmetric with how setWindowRect applies the transformation when setting the rect. BUG=642349 Review-Url: https://codereview.chromium.org/2394073002 Cr-Commit-Position: refs/heads/master@{#423350} (cherry picked from commit 841fdc7222eefdaf63e97f3c57dfe6ea16b6b2b0) Committed: https://chromium.googlesource.com/chromium/src/+/a3bd89f6ac532af8dafda2b264a1fcb1175756ab

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -11 lines) Patch
M content/renderer/devtools/render_widget_screen_metrics_emulator.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 2 chunks +36 lines, -10 lines 0 comments Download
M content/renderer/render_widget_unittest.cc View 2 chunks +128 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
bokan
4 years, 2 months ago (2016-10-07 02:23:02 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a3bd89f6ac532af8dafda2b264a1fcb1175756ab.

Powered by Google App Engine
This is Rietveld 408576698