RenderWidget::windowRect and viewRect should apply device emulation transform.

RenderWidget::windowRect and viewRect should apply device emulation transform.

Since Blink's popup menus now rely on the RenderWidget keeping track of the
view rect, the rect must return the emulated position of the popup. This is
symmetric with how setWindowRect applies the transformation when setting the
rect.

BUG=642349
Committed: https://crrev.com/841fdc7222eefdaf63e97f3c57dfe6ea16b6b2b0
Cr-Commit-Position: refs/heads/master@{#423350}

[bokan, 2016-10-05 22:21:02]

bokan@chromium.org changed reviewers:
+ dgozman@chromium.org

[bokan, 2016-10-05 22:21:02]

Hi Dmitry,

Would you mind taking a look rather soon? This is a regression we'd like to fix
and merge to M54 which is nearing stable. Thanks!

[dgozman, 2016-10-05 22:40:20]

Thank you for the fix! lgtm modulo naming.

https://codereview.chromium.org/2394073002/diff/1/content/renderer/render_wid...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/2394073002/diff/1/content/renderer/render_wid...
content/renderer/render_widget.cc:1374: if (popup_origin_scale_for_emulation_)
Let's maybe call the method unconditionally and early return from it if no
emulation?

https://codereview.chromium.org/2394073002/diff/1/content/renderer/render_wid...
content/renderer/render_widget.cc:1383: ApplyWindowEmulation(&rect);
ScreenRectToEmulated? It's easier to understand conversion methods when they
mention from what to what they convert.

https://codereview.chromium.org/2394073002/diff/1/content/renderer/render_wid...
content/renderer/render_widget.cc:1396: RemoveWindowEmulation(&window_rect);
EmulatedRectToScreen

[bokan, 2016-10-05 22:49:42]

https://codereview.chromium.org/2394073002/diff/1/content/renderer/render_wid...
File content/renderer/render_widget.cc (right):

https://codereview.chromium.org/2394073002/diff/1/content/renderer/render_wid...
content/renderer/render_widget.cc:1374: if (popup_origin_scale_for_emulation_)
On 2016/10/05 22:40:20, dgozman wrote:
> Let's maybe call the method unconditionally and early return from it if no
> emulation?

Done but added |IfNeeded| to the method name to make it clear it's conditional.

https://codereview.chromium.org/2394073002/diff/1/content/renderer/render_wid...
content/renderer/render_widget.cc:1383: ApplyWindowEmulation(&rect);
On 2016/10/05 22:40:20, dgozman wrote:
> ScreenRectToEmulated? It's easier to understand conversion methods when they
> mention from what to what they convert.

Done.

https://codereview.chromium.org/2394073002/diff/1/content/renderer/render_wid...
content/renderer/render_widget.cc:1396: RemoveWindowEmulation(&window_rect);
On 2016/10/05 22:40:20, dgozman wrote:
> EmulatedRectToScreen

Done.

[bokan, 2016-10-05 22:50:02]

bokan@chromium.org changed reviewers:
+ aelias@chromium.org

[bokan, 2016-10-05 22:50:02]

+aelias@ for OWNER

[aelias_OOO_until_Jul13, 2016-10-05 23:12:35]

lgtm

[bokan, 2016-10-05 23:18:10]

The CQ bit was checked by bokan@chromium.org

[bokan, 2016-10-05 23:18:10]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2394073002/#ps20001
(title: "Addressed comments")

[commit-bot: I haz the power, 2016-10-05 23:18:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 00:17:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-06 00:19:32]

Description was changed from

==========
RenderWidget::windowRect and viewRect should apply device emulation transform.

Since Blink's popup menus now rely on the RenderWidget keeping track of the
view rect, the rect must return the emulated position of the popup. This is
symmetric with how setWindowRect applies the transformation when setting the
rect.

BUG=642349
==========

to

==========
RenderWidget::windowRect and viewRect should apply device emulation transform.

Since Blink's popup menus now rely on the RenderWidget keeping track of the
view rect, the rect must return the emulated position of the popup. This is
symmetric with how setWindowRect applies the transformation when setting the
rect.

BUG=642349

Committed: https://crrev.com/841fdc7222eefdaf63e97f3c57dfe6ea16b6b2b0
Cr-Commit-Position: refs/heads/master@{#423350}
==========

[commit-bot: I haz the power, 2016-10-06 00:19:33]

Patchset 2 (id:??) landed as
https://crrev.com/841fdc7222eefdaf63e97f3c57dfe6ea16b6b2b0
Cr-Commit-Position: refs/heads/master@{#423350}