Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2400863005: Reformat comments in core/layout up until LayoutTableRow (Closed)

Created:
4 years, 2 months ago by eae
Modified:
4 years, 2 months ago
Reviewers:
Nico, dgrogan
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reformat comments in core/layout up until LayoutTableRow BUG=563793 R=dgrogan@chromium.org Committed: https://crrev.com/b664f182f72117ad97d2e83206d35edac90bb55e Cr-Commit-Position: refs/heads/master@{#423956}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1557 lines, -1099 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.h View 9 chunks +60 lines, -46 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSet.cpp View 11 chunks +77 lines, -65 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.h View 3 chunks +11 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnSpannerPlaceholder.cpp View 5 chunks +24 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 60 chunks +362 lines, -257 lines 1 comment Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 71 chunks +287 lines, -208 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObjectChildList.cpp View 6 chunks +19 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutPagedFlowThread.h View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutPagedFlowThread.cpp View 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutPart.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutPart.cpp View 9 chunks +37 lines, -30 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutQuote.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutReplaced.h View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutReplaced.cpp View 26 chunks +166 lines, -120 lines 1 comment Download
M third_party/WebKit/Source/core/layout/LayoutRuby.h View 1 chunk +8 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutRuby.cpp View 4 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutRubyBase.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutRubyRun.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutRubyRun.cpp View 5 chunks +14 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutRubyText.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbar.h View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp View 5 chunks +12 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbarPart.h View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutScrollbarPart.cpp View 6 chunks +17 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutSearchField.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutSearchField.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutSliderContainer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutSliderContainer.cpp View 5 chunks +17 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutState.h View 3 chunks +11 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutState.cpp View 3 chunks +9 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.h View 8 chunks +34 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 33 chunks +117 lines, -74 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.h View 7 chunks +22 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCell.cpp View 34 chunks +132 lines, -87 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableCol.cpp View 4 chunks +13 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableRow.h View 3 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableRow.cpp View 10 chunks +37 lines, -24 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
eae
4 years, 2 months ago (2016-10-07 18:45:04 UTC) #1
dgrogan
lgtm https://codereview.chromium.org/2400863005/diff/1/third_party/WebKit/Source/core/layout/LayoutObject.h File third_party/WebKit/Source/core/layout/LayoutObject.h (right): https://codereview.chromium.org/2400863005/diff/1/third_party/WebKit/Source/core/layout/LayoutObject.h#newcode180 third_party/WebKit/Source/core/layout/LayoutObject.h:180: // the suboptimal https://codereview.chromium.org/2400863005/diff/1/third_party/WebKit/Source/core/layout/LayoutReplaced.cpp File third_party/WebKit/Source/core/layout/LayoutReplaced.cpp (right): https://codereview.chromium.org/2400863005/diff/1/third_party/WebKit/Source/core/layout/LayoutReplaced.cpp#newcode389 ...
4 years, 2 months ago (2016-10-07 19:37:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400863005/1
4 years, 2 months ago (2016-10-07 20:32:10 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-07 20:39:26 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 20:41:07 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b664f182f72117ad97d2e83206d35edac90bb55e
Cr-Commit-Position: refs/heads/master@{#423956}

Powered by Google App Engine
This is Rietveld 408576698