Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(483)

Issue 2400863002: Merge to 2840 "[DevTools] Avoid current_ and pending_ being the same host in RenderFrameDevToolsAge… (Closed)

Created:
4 years, 2 months ago by dgozman
Modified:
4 years, 2 months ago
Reviewers:
pfeldman
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Merge to 2840 "[DevTools] Avoid current_ and pending_ being the same host in RenderFrameDevToolsAgentHost." > [DevTools] Avoid current_ and pending_ being the same host in RenderFrameDevToolsAgentHost. > > This happens when we resue RenderFrameHost after crash. > The fix is to commit immediately to avoid pending. This is safe because > we don't even have two RenderFrameHosts. > > BUG=644963 > > Review-Url: https://codereview.chromium.org/2366773003 > Cr-Commit-Position: refs/heads/master@{#421697} (cherry picked from commit f07d611e4c7c7e0b38521119c42166b6104bba1b) TBR=pfeldman Committed: https://chromium.googlesource.com/chromium/src/+/a5593d910bbdacce805ac0e5bd4a139799c7123b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -6 lines) Patch
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 2 chunks +22 lines, -1 line 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 14 chunks +49 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dgozman
4 years, 2 months ago (2016-10-06 23:47:00 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a5593d910bbdacce805ac0e5bd4a139799c7123b.

Powered by Google App Engine
This is Rietveld 408576698