Merge to 2840 "[DevTools] Avoid current_ and pending_ being the same host in RenderFrameDevToolsAge…

content/browser/devtools/protocol/devtools_protocol_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/base64.h"
 #include "base/command_line.h"
 #include "base/json/json_reader.h"
@@ skipping 297 matching lines @@
         } else {
           requested_notification_params_.reset();
         }
         waiting_for_notification_ = std::string();
         base::MessageLoop::current()->QuitNow();
       }
     }
   }
 
   void AgentHostClosed(DevToolsAgentHost* agent_host, bool replaced) override {
-    EXPECT_TRUE(false);
+    DCHECK(false);
   }
 
   std::string waiting_for_notification_;
   int waiting_for_command_result_id_;
   bool in_dispatch_;
 };
 
 class SyntheticKeyEventTest : public DevToolsProtocolTest {
  protected:
   void SendKeyEvent(const std::string& type,
@@ skipping 301 matching lines @@
   // Ensure that the A.com process is still alive by executing a script in the
   // original tab.
   success = false;
   EXPECT_TRUE(ExecuteScriptAndExtractBool(shell(),
                                           "window.domAutomationController.send("
                                           "    !!window.open('', 'foo'));",
                                           &success));
   EXPECT_TRUE(success);
 }
 
+// CrashTab() works differently on Windows, leading to RFH removal before
+// RenderProcessGone is called. TODO(dgozman): figure out the problem.
+#if defined(OS_WIN)
+#define MAYBE_DoubleCrash DISABLED_DoubleCrash
+#else
+#define MAYBE_DoubleCrash DoubleCrash
+#endif
+IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, MAYBE_DoubleCrash) {
+  ASSERT_TRUE(embedded_test_server()->Start());
+  GURL test_url = embedded_test_server()->GetURL("/devtools/navigation.html");
+  NavigateToURLBlockUntilNavigationsComplete(shell(), GURL("about:blank"), 1);
+  Attach();
+  SendCommand("ServiceWorker.enable", nullptr);
+  NavigateToURLBlockUntilNavigationsComplete(shell(), test_url, 1);
+  CrashTab(shell()->web_contents());
+  NavigateToURLBlockUntilNavigationsComplete(shell(), test_url, 1);
+  CrashTab(shell()->web_contents());
+  NavigateToURLBlockUntilNavigationsComplete(shell(), GURL("about:blank"), 1);
+  // Should not crash at this point.
+}
+
 IN_PROC_BROWSER_TEST_F(DevToolsProtocolTest, ReloadBlankPage) {
   Shell* window =  Shell::CreateNewWindow(
       shell()->web_contents()->GetBrowserContext(),
       GURL("javascript:x=1"),
       nullptr,
       gfx::Size());
   WaitForLoadStop(window->web_contents());
   Attach();
   SendCommand("Page.reload", nullptr, false);
   // Should not crash at this point.
@@ skipping 281 matching lines @@
   params->SetString("policy", "advance");
   params->SetInteger("budget", 1000);
   SendCommand("Emulation.setVirtualTimePolicy", std::move(params), true);
 
   WaitForNotification("Emulation.virtualTimeBudgetExpired");
 
   EXPECT_THAT(console_messages_, ElementsAre("before", "done", "after"));
 }
 
 }  // namespace content