Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2400803002: Fix BidirectionalStreamTest#testFailures (Closed)

Created:
4 years, 2 months ago by xunjieli
Modified:
4 years, 2 months ago
Reviewers:
mgersh
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix BidirectionalStreamTest#testFailures Response start can be null or non-null in BidirectionalStream.Callback#onStreamReady() step. TBR=mgersh@chromium.org BUG=653654 Committed: https://crrev.com/a4461011bd1331b61f27ad8fc2e65e53cad92436 Cr-Commit-Position: refs/heads/master@{#423649}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
xunjieli
4 years, 2 months ago (2016-10-06 20:07:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400803002/1
4 years, 2 months ago (2016-10-06 20:08:17 UTC) #6
mgersh
lgtm. maybe we want to rename it to getRequestEnd()?
4 years, 2 months ago (2016-10-06 20:08:43 UTC) #7
xunjieli
On 2016/10/06 20:08:43, mgersh wrote: > lgtm. maybe we want to rename it to getRequestEnd()? ...
4 years, 2 months ago (2016-10-06 20:15:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 20:21:11 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 20:23:22 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4461011bd1331b61f27ad8fc2e65e53cad92436
Cr-Commit-Position: refs/heads/master@{#423649}

Powered by Google App Engine
This is Rietveld 408576698