Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java

Issue 2400803002: Fix BidirectionalStreamTest#testFailures (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java
index 5a296f006c92ef630f7a5c695c5c957a55e0ee67..75f8ff427121ad3bf34e4635b65a198fbc0b3269 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java
@@ -1202,7 +1202,9 @@ public class BidirectionalStreamTest extends CronetTestBase {
assertNotNull(metrics.getRequestStart());
MetricsTestUtil.assertAfter(metrics.getRequestStart(), startTime);
MetricsTestUtil.checkNoConnectTiming(metrics);
- assertNull(metrics.getResponseStart());
+ // metrics.getResponseStart() can be null or non null
+ // TODO(xunjieli): It's weird to have a null response start but a
+ // non-null response end.
assertNotNull(metrics.getResponseEnd());
MetricsTestUtil.assertAfter(endTime, metrics.getResponseEnd());
// Entire request should take more than 0 ms
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698