Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: chrome/android/java/ChromeVersionConstants.java.version

Issue 2400793003: [Signin] Update sign in promo triggering logic (Closed)
Patch Set: address comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/ChromeVersionConstants.java.version
diff --git a/chrome/android/java/ChromeVersionConstants.java.version b/chrome/android/java/ChromeVersionConstants.java.version
index 81e981e066dae9c48d2caf3cbe7160c31f2d7e68..c8be2dcf4b1f1230fcb28335c63001125c8703ce 100644
--- a/chrome/android/java/ChromeVersionConstants.java.version
+++ b/chrome/android/java/ChromeVersionConstants.java.version
@@ -7,6 +7,7 @@ package org.chromium.chrome.browser;
class ChromeVersionConstants {
static final String PRODUCT_NAME = "@PRODUCT_FULLNAME@";
static final String PRODUCT_VERSION = "@MAJOR@.@MINOR@.@BUILD@.@PATCH@";
+ static final String PRODUCT_MAJOR_VERSION = "@MAJOR@";
Bernhard Bauer 2016/10/07 16:17:23 I think you can make this directly an int :)
gogerald1 2016/10/07 17:51:09 Done. It looks inconsistent for getProductVersion
Bernhard Bauer 2016/10/08 13:54:51 Eh :) The latter is meant to be numeric, and the f
static final boolean IS_OFFICIAL_BUILD = @OFFICIAL_BUILD@ == 1;
static final int CHANNEL_DEFAULT = 0;
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698