Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1015)

Issue 2400793002: [Merge to M54] Manifests for Get Help app and Help app updated in regard to removal of RTS/Helpouts… (Closed)

Created:
4 years, 2 months ago by afakhry
Modified:
4 years, 2 months ago
Reviewers:
morsed, xiyuan, cylee, cnwan
CC:
chromium-reviews, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

[Merge to M54] Manifests for Get Help app and Help app updated in regard to removal of RTS/Helpouts code, removed in relation to Contact Support button update. Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. These need to be merged back into M54 to match with primary ChromiumOS updates at https://chrome-internal-review.googlesource.com/#/c/291159/ TBR=morsed@chromium.com, cylee@chromium.com, cnwan@chromium.com, xiyuan@chromium.com BUG=622920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2376883002 Cr-Commit-Position: refs/heads/master@{#422520} (cherry picked from commit 30c0d60853a51a88dff7f85770c47b2bce18b818) Committed: https://chromium.googlesource.com/chromium/src/+/445f92bfbb12bc0924f81bf4488b4fe392888852

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -30 lines) Patch
M chrome/browser/resources/chromeos/genius_app/manifest.json View 3 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/resources/help_app/manifest.json View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 4 (3 generated)
afakhry
4 years, 2 months ago (2016-10-06 19:59:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
445f92bfbb12bc0924f81bf4488b4fe392888852 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698