Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2376883002:
GetHelp/HelpApp: manifests updated for M54 (Closed)
DescriptionManifests for Get Help app and Help app updated in regard to removal of RTS/Helpouts code, removed in relation to Contact Support button update.
Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp.
These need to be merged back into M54 to match with primary ChromiumOS updates at https://chrome-internal-review.googlesource.com/#/c/291159/
BUG=622920
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/30c0d60853a51a88dff7f85770c47b2bce18b818
Cr-Commit-Position: refs/heads/master@{#422520}
Patch Set 1 #
Messages
Total messages: 44 (28 generated)
Description was changed from ========== GetHelp/HelpApp: manifests updated Contact Support button updated, remove RTS/Helpouts code Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. BUG=622920 ========== to ========== GetHelp/HelpApp: manifests updated Contact Support button updated, remove RTS/Helpouts code Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. BUG=622920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== GetHelp/HelpApp: manifests updated Contact Support button updated, remove RTS/Helpouts code Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. BUG=622920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== GetHelp/HelpApp: manifests updated Contact Support button updated, remove RTS/Helpouts code Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. BUG=622920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
morsed@google.com changed reviewers: + cnwan@chromium.org, cylee@chromium.org
Description was changed from ========== GetHelp/HelpApp: manifests updated Contact Support button updated, remove RTS/Helpouts code Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. BUG=622920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== GetHelp/HelpApp: manifests updated Related to Contact Support button updated, remove RTS/Helpouts code. Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. BUG=622920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
LGTM 1. I'm not sure if you need a LGTM from a committer. I'm no committer. 2. It's better to submit this CL *AFTER* the ChromeOS side CL has been submitted.
On 2016/09/28 18:43:09, cylee1 wrote: > LGTM > > 1. I'm not sure if you need a LGTM from a committer. I'm no committer. > > 2. It's better to submit this CL *AFTER* the ChromeOS side CL has been > submitted. 1) abodenha@ said once we have merge approval, any committer can do it, which is most of the team. 2) noted for future reference. and now the chromiumOS side is committed and uploaded: https://chrome-internal-review.googlesource.com/#/c/291159/
morsed@google.com changed reviewers: + davidyu@chromium.org
lgtm
cnwan@chromium.org changed reviewers: - davidyu@chromium.org
The CQ bit was checked by cnwan@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by afakhry@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by morsed@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
morsed@google.com changed reviewers: + sky@chromium.org
The CQ bit was unchecked by morsed@google.com
The CQ bit was checked by morsed@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
Description was changed from ========== GetHelp/HelpApp: manifests updated Related to Contact Support button updated, remove RTS/Helpouts code. Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. BUG=622920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== GetHelp/HelpApp: manifests updated for M54 Related to Contact Support button updated, remove RTS/Helpouts code. Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. BUG=622920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== GetHelp/HelpApp: manifests updated for M54 Related to Contact Support button updated, remove RTS/Helpouts code. Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. BUG=622920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Related to Contact Support button being updated and removal of RTS/Helpouts code. Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. BUG=622920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Related to Contact Support button being updated and removal of RTS/Helpouts code. Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. BUG=622920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Related to Contact Support button being updated and removal of RTS/Helpouts code. Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. BUG=b:31310862 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Related to Contact Support button being updated and removal of RTS/Helpouts code. Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. BUG=b:31310862 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Related to Contact Support button being updated and removal of RTS/Helpouts code. Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. BUG=31310862 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Related to Contact Support button being updated and removal of RTS/Helpouts code. Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. BUG=31310862 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Related to Contact Support button being updated and removal of RTS/Helpouts code. Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. BUG=622920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Related to Contact Support button being updated and removal of RTS/Helpouts code. Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. BUG=622920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Manifests for Get Help app and Help app updated in regard to removal of RTS/Helpouts code, removed in relation to Contact Support button update. Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. Related to primary updates at https://chrome-internal-review.googlesource.com/#/c/291159/ BUG=622920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Manifests for Get Help app and Help app updated in regard to removal of RTS/Helpouts code, removed in relation to Contact Support button update. Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. Related to primary updates at https://chrome-internal-review.googlesource.com/#/c/291159/ BUG=622920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Manifests for Get Help app and Help app updated in regard to removal of RTS/Helpouts code, removed in relation to Contact Support button update. Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. These need to be merged back into M54 to match with primary ChromiumOS updates at https://chrome-internal-review.googlesource.com/#/c/291159/ BUG=622920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
sky@chromium.org changed reviewers: - sky@chromium.org
sky@chromium.org changed reviewers: + xiyuan@chromium.org
I'm not a good reviewer for this, -sky. I recommend trying xiyuan, so adding him.
Thank you.
lgtm
The CQ bit was checked by morsed@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Manifests for Get Help app and Help app updated in regard to removal of RTS/Helpouts code, removed in relation to Contact Support button update. Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. These need to be merged back into M54 to match with primary ChromiumOS updates at https://chrome-internal-review.googlesource.com/#/c/291159/ BUG=622920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Manifests for Get Help app and Help app updated in regard to removal of RTS/Helpouts code, removed in relation to Contact Support button update. Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. These need to be merged back into M54 to match with primary ChromiumOS updates at https://chrome-internal-review.googlesource.com/#/c/291159/ BUG=622920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Manifests for Get Help app and Help app updated in regard to removal of RTS/Helpouts code, removed in relation to Contact Support button update. Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. These need to be merged back into M54 to match with primary ChromiumOS updates at https://chrome-internal-review.googlesource.com/#/c/291159/ BUG=622920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Manifests for Get Help app and Help app updated in regard to removal of RTS/Helpouts code, removed in relation to Contact Support button update. Contact Support button previously opened non-working/deprecated Real-Time Support/Helpouts. Updated Contact button now links to online OEM resource. All code related to deprecated RTS removed from Get Help and HelpApp. These need to be merged back into M54 to match with primary ChromiumOS updates at https://chrome-internal-review.googlesource.com/#/c/291159/ BUG=622920 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/30c0d60853a51a88dff7f85770c47b2bce18b818 Cr-Commit-Position: refs/heads/master@{#422520} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/30c0d60853a51a88dff7f85770c47b2bce18b818 Cr-Commit-Position: refs/heads/master@{#422520} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
