chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java - Issue 2400783003: Ntp: show AllDismissedItem when all sections have been dismissed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

Issue 2400783003: Ntp: show AllDismissedItem when all sections have been dismissed. (Closed)

Patch Set: Address review comments. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/AllDismissedItem.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java » ('j') | components/ntp_snippets/content_suggestions_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

index f4b88965a18aed3db76841796062c22d209c4a9f..f5d553ee12475391acf8b99871ac5c96f0ff3bd2 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java

@@ -245,6 +245,7 @@ public class CardViewHolder extends NewTabPageViewHolder {

case NewTabPageItem.VIEW_TYPE_SPACING:

case NewTabPageItem.VIEW_TYPE_PROGRESS:

case NewTabPageItem.VIEW_TYPE_FOOTER:

+ case NewTabPageItem.VIEW_TYPE_ALL_DISMISSED:

return false;

default:

assert false;