chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java - Issue 2400783003: Ntp: show AllDismissedItem when all sections have been dismissed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java

Issue 2400783003: Ntp: show AllDismissedItem when all sections have been dismissed. (Closed)

Patch Set: Address review comments. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/layout/new_tab_page_all_dismissed.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/AllDismissedItem.java » ('j') | components/ntp_snippets/content_suggestions_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java

index 8c4372ef81ad0cd9ff5d16075d0a29d46626b422..259be62fac728b0eeb5748e1db7701ee185bb22e 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageUma.java

@@ -52,8 +52,10 @@ public final class NewTabPageUma {

public static final int ACTION_CLICKED_INTEREST = 8;

Marc Treib 2016/10/11 12:18:14 Unrelated, but: This is unused. Maybe remove it, o

Michael van Ouwerkerk 2016/10/11 15:21:31 I added a TODO for removing it and cleaning up his

// User clicked on the "learn more" link in the footer.

public static final int ACTION_CLICKED_LEARN_MORE = 9;

+ // User clicked on the "Refresh" button in the "all dismissed" state.

+ public static final int ACTION_CLICKED_ALL_DISMISSED_REFRESH = 10;

// The number of possible actions

- private static final int NUM_ACTIONS = 10;

+ private static final int NUM_ACTIONS = 11;

// User navigated to a page using the omnibox.

private static final int RAPPOR_ACTION_NAVIGATED_USING_OMNIBOX = 0;