Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: components/ntp_snippets/content_suggestions_service.cc

Issue 2400783003: Ntp: show AllDismissedItem when all sections have been dismissed. (Closed)
Patch Set: Rebase. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/content_suggestions_service.cc
diff --git a/components/ntp_snippets/content_suggestions_service.cc b/components/ntp_snippets/content_suggestions_service.cc
index f52a9809d09dcae42dbad4cd9a62ff9598870423..8b1bdc15eae83a3180fece814448f8805d01484f 100644
--- a/components/ntp_snippets/content_suggestions_service.cc
+++ b/components/ntp_snippets/content_suggestions_service.cc
@@ -150,11 +150,24 @@ void ContentSuggestionsService::DismissCategory(Category category) {
if (providers_it == providers_by_category_.end())
return;
+ suggestions_by_category_[category].clear();
+ dismissed_providers_by_category_[providers_it->first] = providers_it->second;
providers_by_category_.erase(providers_it);
categories_.erase(
std::find(categories_.begin(), categories_.end(), category));
}
+void ContentSuggestionsService::RestoreDismissedCategories() {
+ // Make a copy as the original will be modified during iteration.
+ auto dismissed_providers_by_category_copy = dismissed_providers_by_category_;
+ for (const auto& category_provider_pair :
+ dismissed_providers_by_category_copy) {
+ RegisterCategoryIfRequired(category_provider_pair.second,
+ category_provider_pair.first);
+ }
+ DCHECK(dismissed_providers_by_category_.empty());
+}
+
void ContentSuggestionsService::AddObserver(Observer* observer) {
observers_.AddObserver(observer);
}
@@ -274,6 +287,12 @@ bool ContentSuggestionsService::RegisterCategoryIfRequired(
return false;
}
+ auto dismissed_it = dismissed_providers_by_category_.find(category);
+ if (dismissed_it != dismissed_providers_by_category_.end()) {
+ DCHECK_EQ(dismissed_it->second, provider);
+ dismissed_providers_by_category_.erase(dismissed_it);
+ }
+
providers_by_category_[category] = provider;
categories_.push_back(category);
SortCategories();
« no previous file with comments | « components/ntp_snippets/content_suggestions_service.h ('k') | components/ntp_snippets/content_suggestions_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698