Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Side by Side Diff: components/ntp_snippets/content_suggestions_service.cc

Issue 2400783003: Ntp: show AllDismissedItem when all sections have been dismissed. (Closed)
Patch Set: Rebase. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/ntp_snippets/content_suggestions_service.h" 5 #include "components/ntp_snippets/content_suggestions_service.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <iterator> 8 #include <iterator>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 DCHECK(removed) << "The dismissed suggestion " << suggestion_id 143 DCHECK(removed) << "The dismissed suggestion " << suggestion_id
144 << " has already been removed. Providers must not call" 144 << " has already been removed. Providers must not call"
145 << " OnNewSuggestions in response to DismissSuggestion."; 145 << " OnNewSuggestions in response to DismissSuggestion.";
146 } 146 }
147 147
148 void ContentSuggestionsService::DismissCategory(Category category) { 148 void ContentSuggestionsService::DismissCategory(Category category) {
149 auto providers_it = providers_by_category_.find(category); 149 auto providers_it = providers_by_category_.find(category);
150 if (providers_it == providers_by_category_.end()) 150 if (providers_it == providers_by_category_.end())
151 return; 151 return;
152 152
153 suggestions_by_category_[category].clear();
154 dismissed_providers_by_category_[providers_it->first] = providers_it->second;
153 providers_by_category_.erase(providers_it); 155 providers_by_category_.erase(providers_it);
154 categories_.erase( 156 categories_.erase(
155 std::find(categories_.begin(), categories_.end(), category)); 157 std::find(categories_.begin(), categories_.end(), category));
156 } 158 }
157 159
160 void ContentSuggestionsService::RestoreDismissedCategories() {
161 // Make a copy as the original will be modified during iteration.
162 auto dismissed_providers_by_category_copy = dismissed_providers_by_category_;
163 for (const auto& category_provider_pair :
164 dismissed_providers_by_category_copy) {
165 RegisterCategoryIfRequired(category_provider_pair.second,
166 category_provider_pair.first);
167 }
168 DCHECK(dismissed_providers_by_category_.empty());
169 }
170
158 void ContentSuggestionsService::AddObserver(Observer* observer) { 171 void ContentSuggestionsService::AddObserver(Observer* observer) {
159 observers_.AddObserver(observer); 172 observers_.AddObserver(observer);
160 } 173 }
161 174
162 void ContentSuggestionsService::RemoveObserver(Observer* observer) { 175 void ContentSuggestionsService::RemoveObserver(Observer* observer) {
163 observers_.RemoveObserver(observer); 176 observers_.RemoveObserver(observer);
164 } 177 }
165 178
166 void ContentSuggestionsService::RegisterProvider( 179 void ContentSuggestionsService::RegisterProvider(
167 std::unique_ptr<ContentSuggestionsProvider> provider) { 180 std::unique_ptr<ContentSuggestionsProvider> provider) {
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
267 280
268 bool ContentSuggestionsService::RegisterCategoryIfRequired( 281 bool ContentSuggestionsService::RegisterCategoryIfRequired(
269 ContentSuggestionsProvider* provider, 282 ContentSuggestionsProvider* provider,
270 Category category) { 283 Category category) {
271 auto it = providers_by_category_.find(category); 284 auto it = providers_by_category_.find(category);
272 if (it != providers_by_category_.end()) { 285 if (it != providers_by_category_.end()) {
273 DCHECK_EQ(it->second, provider); 286 DCHECK_EQ(it->second, provider);
274 return false; 287 return false;
275 } 288 }
276 289
290 auto dismissed_it = dismissed_providers_by_category_.find(category);
291 if (dismissed_it != dismissed_providers_by_category_.end()) {
292 DCHECK_EQ(dismissed_it->second, provider);
293 dismissed_providers_by_category_.erase(dismissed_it);
294 }
295
277 providers_by_category_[category] = provider; 296 providers_by_category_[category] = provider;
278 categories_.push_back(category); 297 categories_.push_back(category);
279 SortCategories(); 298 SortCategories();
280 if (IsCategoryStatusAvailable(provider->GetCategoryStatus(category))) { 299 if (IsCategoryStatusAvailable(provider->GetCategoryStatus(category))) {
281 suggestions_by_category_.insert( 300 suggestions_by_category_.insert(
282 std::make_pair(category, std::vector<ContentSuggestion>())); 301 std::make_pair(category, std::vector<ContentSuggestion>()));
283 } 302 }
284 return true; 303 return true;
285 } 304 }
286 305
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 if (left.IsKnownCategory(KnownCategories::BOOKMARKS)) 344 if (left.IsKnownCategory(KnownCategories::BOOKMARKS))
326 return false; 345 return false;
327 if (right.IsKnownCategory(KnownCategories::BOOKMARKS)) 346 if (right.IsKnownCategory(KnownCategories::BOOKMARKS))
328 return true; 347 return true;
329 } 348 }
330 return category_factory_.CompareCategories(left, right); 349 return category_factory_.CompareCategories(left, right);
331 }); 350 });
332 } 351 }
333 352
334 } // namespace ntp_snippets 353 } // namespace ntp_snippets
OLDNEW
« no previous file with comments | « components/ntp_snippets/content_suggestions_service.h ('k') | components/ntp_snippets/content_suggestions_service_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698