Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2400723005: Revert of Cache SubResourceIntegrity checks at Resource (patchset #2 id:20001 of https://codereview… (Closed)

Created:
4 years, 2 months ago by nasko
Modified:
4 years, 2 months ago
CC:
chromium-reviews, tyoshino+watch_chromium.org, sof, eae+blinkwatch, Yoav Weiss, blink-reviews-dom_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Cache SubResourceIntegrity checks at Resource (patchset #2 id:20001 of https://codereview.chromium.org/2398733003/ ) Reason for revert: Reverting due to failing PageLoadMetricsBrowserTest.IgnoreDownloads test starting with this CL. https://build.chromium.org/p/chromium.win/builders/Win7%20%2832%29%20Tests/builds/10984 Original issue's description: > Cache SubResourceIntegrity checks at Resource > > Move SubResourceIntegrity check caches from ScriptResource -> Resource. > This also renames ScriptIntegrityDisposition to generic name ResourceIntegrityDisposition > > This is to prepare for CSSStyleSheetResource to use the same logic. > Split from https://codereview.chromium.org/2290983003/. > > BUG=642722 > > Committed: https://crrev.com/6e09a67eb013cde927f50ac7931018a15bfdb2ba > Cr-Commit-Position: refs/heads/master@{#423792} TBR=jww@chromium.org,csharrison@chromium.org,kouhei@chromium.org BUG=642722 Committed: https://crrev.com/7c28430f36a95d35778beb97b31b1c188f37c76e Cr-Commit-Position: refs/heads/master@{#423946}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -50 lines) Patch
M third_party/WebKit/Source/core/dom/PendingScript.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/IntegrityMetadata.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.h View 4 chunks +5 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 3 chunks +0 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ScriptResource.h View 2 chunks +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/ScriptResource.cpp View 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400723005/1
4 years, 2 months ago (2016-10-07 18:09:57 UTC) #2
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 2 months ago (2016-10-07 20:03:01 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7c28430f36a95d35778beb97b31b1c188f37c76e Cr-Commit-Position: refs/heads/master@{#423946}
4 years, 2 months ago (2016-10-07 20:04:01 UTC) #6
nasko
4 years, 2 months ago (2016-10-07 21:45:52 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2398733005/ by nasko@chromium.org.

The reason for reverting is: Reverting the revert, as the test continues
failing..

Powered by Google App Engine
This is Rietveld 408576698