Cache SubResourceIntegrity checks at Resource

Cache SubResourceIntegrity checks at Resource

Move SubResourceIntegrity check caches from ScriptResource -> Resource.
This also renames ScriptIntegrityDisposition to generic name ResourceIntegrityDisposition

This is to prepare for CSSStyleSheetResource to use the same logic.
Split from https://codereview.chromium.org/2290983003/.

BUG=642722
Committed: https://crrev.com/6e09a67eb013cde927f50ac7931018a15bfdb2ba
Cr-Commit-Position: refs/heads/master@{#423792}

[kouhei (in TOK), 2016-10-06 09:22:35]

The CQ bit was checked by kouhei@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 09:22:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kouhei (in TOK), 2016-10-06 09:24:03]

Description was changed from

==========
Cache SubResourceIntegrity checks at Resource

BUG=642722
==========

to

==========
Cache SubResourceIntegrity checks at Resource

Move SubResourceIntegrity check caches from ScriptResource -> Resource.
This also renames ScriptIntegrityDisposition to generic name
ResourceIntegrityDisposition

This is to prepare for CSSStyleSheetResource to use the same logic.
Split from https://codereview.chromium.org/2290983003/.


BUG=642722
==========

[kouhei (in TOK), 2016-10-06 09:24:03]

kouhei@chromium.org changed reviewers:
+ csharrison@chromium.org, jww@chromium.org

[commit-bot: I haz the power, 2016-10-06 10:42:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 10:42:07]

Dry run: This issue passed the CQ dry run.

[Charlie Harrison, 2016-10-06 12:15:39]

non-owner LGTM

[jww, 2016-10-06 20:42:45]

lgtm w/nit

https://codereview.chromium.org/2398733003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/Resource.cpp (right):

https://codereview.chromium.org/2398733003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/Resource.cpp:465: return
!IntegrityMetadata::setsEqual(m_integrityMetadata,
nit: Please #include IntegrityMetadata.h

[kouhei (in TOK), 2016-10-07 01:48:55]

The CQ bit was checked by kouhei@chromium.org to run a CQ dry run

[kouhei (in TOK), 2016-10-07 01:48:59]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2016-10-07 01:48:59]

The patchset sent to the CQ was uploaded after l-g-t-m from jww@chromium.org,
csharrison@chromium.org
Link to the patchset: https://codereview.chromium.org/2398733003/#ps20001
(title: "add include")

[kouhei (in TOK), 2016-10-07 01:49:16]

https://codereview.chromium.org/2398733003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/fetch/Resource.cpp (right):

https://codereview.chromium.org/2398733003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/fetch/Resource.cpp:465: return
!IntegrityMetadata::setsEqual(m_integrityMetadata,
On 2016/10/06 20:42:45, jww wrote:
> nit: Please #include IntegrityMetadata.h

Done.

[commit-bot: I haz the power, 2016-10-07 01:49:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 03:12:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 03:12:31]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[kouhei (in TOK), 2016-10-07 03:16:45]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2016-10-07 03:16:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 04:02:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 04:02:29]

Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

[commit-bot: I haz the power, 2016-10-07 04:04:32]

Description was changed from

==========
Cache SubResourceIntegrity checks at Resource

Move SubResourceIntegrity check caches from ScriptResource -> Resource.
This also renames ScriptIntegrityDisposition to generic name
ResourceIntegrityDisposition

This is to prepare for CSSStyleSheetResource to use the same logic.
Split from https://codereview.chromium.org/2290983003/.


BUG=642722
==========

to

==========
Cache SubResourceIntegrity checks at Resource

Move SubResourceIntegrity check caches from ScriptResource -> Resource.
This also renames ScriptIntegrityDisposition to generic name
ResourceIntegrityDisposition

This is to prepare for CSSStyleSheetResource to use the same logic.
Split from https://codereview.chromium.org/2290983003/.

BUG=642722

Committed: https://crrev.com/6e09a67eb013cde927f50ac7931018a15bfdb2ba
Cr-Commit-Position: refs/heads/master@{#423792}
==========

[commit-bot: I haz the power, 2016-10-07 04:04:33]

Patchset 2 (id:??) landed as
https://crrev.com/6e09a67eb013cde927f50ac7931018a15bfdb2ba
Cr-Commit-Position: refs/heads/master@{#423792}

[nasko, 2016-10-07 17:41:53]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2397423003/ by nasko@chromium.org.

The reason for reverting is: Reverting due to failing
PageLoadMetricsBrowserTest.IgnoreDownloads test starting with this CL.

https://build.chromium.org/p/chromium.win/builders/Win7%20%2832%29%20Tests/bu....