Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issue 2400723002: Early out when setting global root scroller (Closed)

Created:
4 years, 2 months ago by ymalik
Modified:
4 years, 2 months ago
Reviewers:
bokan
CC:
chromium-reviews, blink-reviews, kenneth.christiansen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Early out when setting global root scroller BUG=505516 Committed: https://crrev.com/4dd6ed6e87487521e012f5b526556634c25c42ff Cr-Commit-Position: refs/heads/master@{#423700}

Patch Set 1 #

Patch Set 2 : presubmit #

Patch Set 3 : undo errenous patchset #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/RootFrameViewport.cpp View 2 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp View 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
ymalik
4 years, 2 months ago (2016-10-06 18:03:44 UTC) #3
ymalik
4 years, 2 months ago (2016-10-06 18:03:50 UTC) #4
bokan
lgtm
4 years, 2 months ago (2016-10-06 18:07:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400723002/40001
4 years, 2 months ago (2016-10-06 19:43:17 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-06 21:51:19 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 21:54:50 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4dd6ed6e87487521e012f5b526556634c25c42ff
Cr-Commit-Position: refs/heads/master@{#423700}

Powered by Google App Engine
This is Rietveld 408576698