third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp - Issue 2400723002: Early out when setting global root scroller

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp

Issue 2400723002: Early out when setting global root scroller (Closed)

Patch Set: undo errenous patchset Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp

diff --git a/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp b/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp

index a69570ac7c560964a861472af6efc7991e2ca46b..a30490f1c65d86fe91f248096ea91f975cd33ec7 100644

--- a/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp

+++ b/third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp

@@ -69,7 +69,7 @@ void TopDocumentRootScrollerController::recomputeGlobalRootScroller() {

return;

Element* target = findGlobalRootScrollerElement();

- if (!target)

+ if (!target || target == m_globalRootScroller)

return;

ScrollableArea* targetScroller = RootScrollerUtil::scrollableAreaFor(*target);

« no previous file with comments | « third_party/WebKit/Source/core/frame/RootFrameViewport.cpp ('k') | no next file » | no next file with comments »