Fix policy checks for chrome://policy

components/search_engines/default_search_policy_handler.cc

Index: components/search_engines/default_search_policy_handler.cc
diff --git a/components/search_engines/default_search_policy_handler.cc b/components/search_engines/default_search_policy_handler.cc
index a2837ee8a1232e0a9a5df5dc1e99bd1ce4574e14..4c273ec1c66ab28e919a6640d3e9cda19e2e1a8c 100644
--- a/components/search_engines/default_search_policy_handler.cc
+++ b/components/search_engines/default_search_policy_handler.cc
@@ -301,11 +301,12 @@ void DefaultSearchPolicyHandler::ApplyPolicySettings(const PolicyMap& policies,
 bool DefaultSearchPolicyHandler::CheckIndividualPolicies(
     const PolicyMap& policies,
     PolicyErrorMap* errors) {
+  bool all_ok = true;

[Peter Kasting, 2016/10/10 19:39:33]

Nit: I had to look at several things to understand why you were making this
change, so I suggest documenting this with an added comment, e.g.:

It's important to call CheckPolicySettings() on all handlers and not just exit
on the first error, so we report all policy errors.

[aberent, 2016/10/13 15:10:01]

Done.

   for (const auto& handler : handlers_) {
     if (!handler->CheckPolicySettings(policies, errors))
-      return false;
+      all_ok = false;

[Peter Kasting, 2016/10/10 19:39:33]

Nit: Shorter:

  for (const auto& handler : handlers_)
    all_ok &= handler->CheckPolicySettings(policies, errors);

[aberent, 2016/10/13 15:10:01]

Done.

   }
-  return true;
+  return all_ok;
 }
 
 bool DefaultSearchPolicyHandler::HasDefaultSearchPolicy(