Fix policy checks for chrome://policy

components/search_engines/default_search_policy_handler.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/search_engines/default_search_policy_handler.h"
 
 #include <stddef.h>
 
 #include <utility>
 
@@ skipping 283 matching lines @@
     dict->SetString(DefaultSearchManager::kShortName, host);
   if (keyword.empty())
     dict->SetString(DefaultSearchManager::kKeyword, host);
 
   DefaultSearchManager::AddPrefValueToMap(std::move(dict), prefs);
 }
 
 bool DefaultSearchPolicyHandler::CheckIndividualPolicies(
     const PolicyMap& policies,
     PolicyErrorMap* errors) {
+  bool all_ok = true;

[Peter Kasting, 2016/10/10 19:39:33]

Nit: I had to look at several things to understand why you were making this
change, so I suggest documenting this with an added comment, e.g.:

It's important to call CheckPolicySettings() on all handlers and not just exit
on the first error, so we report all policy errors.

[aberent, 2016/10/13 15:10:01]

Done.

   for (const auto& handler : handlers_) {
     if (!handler->CheckPolicySettings(policies, errors))
-      return false;
+      all_ok = false;

[Peter Kasting, 2016/10/10 19:39:33]

Nit: Shorter:

  for (const auto& handler : handlers_)
    all_ok &= handler->CheckPolicySettings(policies, errors);

[aberent, 2016/10/13 15:10:01]

Done.

   }
-  return true;
+  return all_ok;
 }
 
 bool DefaultSearchPolicyHandler::HasDefaultSearchPolicy(
     const PolicyMap& policies,
     const char* policy_name) {
   return policies.Get(policy_name) != NULL;
 }
 
 bool DefaultSearchPolicyHandler::AnyDefaultSearchPoliciesSpecified(
     const PolicyMap& policies) {
@@ skipping 38 matching lines @@
 void DefaultSearchPolicyHandler::EnsureListPrefExists(
     PrefValueMap* prefs,
     const std::string& path) {
   base::Value* value;
   base::ListValue* list_value;
   if (!prefs->GetValue(path, &value) || !value->GetAsList(&list_value))
     prefs->SetValue(path, base::MakeUnique<base::ListValue>());
 }
 
 }  // namespace policy