Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2400613002: Fix some accessibility issues in image editing. (Closed)

Created:
4 years, 2 months ago by fukino
Modified:
4 years, 2 months ago
Reviewers:
oka
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix some accessibility issues in image editing. - Fix tab order on editing tool bar by swapping containers. - Add background color for focused buttons on editing tool. - When a editing tool is shown, the first input element should be focused. BUG=652352 TEST=manual CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/463197f1254e1fa220a24f8d2229b879be85bfc4 Cr-Commit-Position: refs/heads/master@{#423615}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -11 lines) Patch
M ui/file_manager/gallery/css/gallery.css View 2 chunks +8 lines, -3 lines 2 comments Download
M ui/file_manager/gallery/js/image_editor/image_editor.js View 3 chunks +16 lines, -8 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_transform.js View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 14 (8 generated)
fukino
PTAL
4 years, 2 months ago (2016-10-06 08:07:02 UTC) #7
oka
lgtm LGMT with nits. https://codereview.chromium.org/2400613002/diff/1/ui/file_manager/gallery/css/gallery.css File ui/file_manager/gallery/css/gallery.css (right): https://codereview.chromium.org/2400613002/diff/1/ui/file_manager/gallery/css/gallery.css#newcode846 ui/file_manager/gallery/css/gallery.css:846: background-color: rgba(255, 255, 255, 0.12); ...
4 years, 2 months ago (2016-10-06 09:11:55 UTC) #8
fukino
https://codereview.chromium.org/2400613002/diff/1/ui/file_manager/gallery/css/gallery.css File ui/file_manager/gallery/css/gallery.css (right): https://codereview.chromium.org/2400613002/diff/1/ui/file_manager/gallery/css/gallery.css#newcode846 ui/file_manager/gallery/css/gallery.css:846: background-color: rgba(255, 255, 255, 0.12); On 2016/10/06 09:11:55, oka ...
4 years, 2 months ago (2016-10-06 14:34:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400613002/1
4 years, 2 months ago (2016-10-06 18:49:06 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-06 18:58:22 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 18:59:57 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/463197f1254e1fa220a24f8d2229b879be85bfc4
Cr-Commit-Position: refs/heads/master@{#423615}

Powered by Google App Engine
This is Rietveld 408576698