Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Unified Diff: ui/file_manager/gallery/js/image_editor/image_transform.js

Issue 2400613002: Fix some accessibility issues in image editing. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/gallery/js/image_editor/image_transform.js
diff --git a/ui/file_manager/gallery/js/image_editor/image_transform.js b/ui/file_manager/gallery/js/image_editor/image_transform.js
index 2f06b831d595668c6ebd09db40ff3bae992474cd..aa5ae345a9dc043e9c78c77233794768068206b0 100644
--- a/ui/file_manager/gallery/js/image_editor/image_transform.js
+++ b/ui/file_manager/gallery/js/image_editor/image_transform.js
@@ -143,6 +143,7 @@ ImageEditor.Mode.Crop.prototype.createTools = function(toolbar) {
GALLERY_ASPECT_RATIO_16_9: 16 / 9
};
+ // TODO(fukino): The loop order is not guaranteed. Fix it!
oka 2016/10/06 09:11:55 suggestion: Consider using Map. A Map object itera
fukino 2016/10/06 14:34:30 Map can be used if tooling support works well. I'l
for (var name in aspects) {
var button = toolbar.addButton(
name,

Powered by Google App Engine
This is Rietveld 408576698