Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 2400593002: Mus+Ash: Fix the FrameSinkId of the FrameGenerator's CompositorFrameSink (Closed)

Created:
4 years, 2 months ago by Fady Samuel
Modified:
4 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mus+Ash: Fix the FrameSinkId of the FrameGenerator's CompositorFrameSink Previously, FrameSinkId collisions would have been possible. This CL gives FrameGenerator a unique client_id (0), and an autogenerated sink_id. BUG=647852 Committed: https://crrev.com/336ebec0b9ddbb32b59d30106bf5c47ab460e4f0 Cr-Commit-Position: refs/heads/master@{#423582}

Patch Set 1 #

Patch Set 2 : Fixed FrameGeneratorTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M services/ui/surfaces/compositor_frame_sink.h View 1 chunk +1 line, -0 lines 0 comments Download
M services/ui/surfaces/compositor_frame_sink.cc View 1 chunk +2 lines, -1 line 0 comments Download
M services/ui/ws/frame_generator.h View 2 chunks +2 lines, -0 lines 0 comments Download
M services/ui/ws/frame_generator.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M services/ui/ws/frame_generator_unittest.cc View 1 4 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Fady Samuel
PTAL
4 years, 2 months ago (2016-10-06 05:58:47 UTC) #2
sky
LGTM
4 years, 2 months ago (2016-10-06 17:32:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400593002/20001
4 years, 2 months ago (2016-10-06 17:48:35 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-06 17:55:01 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-10-06 17:56:41 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/336ebec0b9ddbb32b59d30106bf5c47ab460e4f0
Cr-Commit-Position: refs/heads/master@{#423582}

Powered by Google App Engine
This is Rietveld 408576698