ash: Remove broken display notification suppression when settings is open

ash: Remove broken display notification suppression when settings is open

On Chrome OS we used to have code that suppressed showing a display change
notification (e.g. resolution changed) when the display settings UI was
visible. This broke when settings moved from being shown in a tab to being
shown in a window. We always show the notifications, and have been doing so
for about 2 years.

I spoke with PM tbuckley@ and he's OK with always showing the notifications
I've deleted the code that was trying to suppress them, effectively doing a
manual revert of http://crrev.com/208299

This simplifies ash::SystemTrayDelegate and removes one method I would have
to port to mojo for mustash.

BUG=246271, 647412
TEST=ash_unittests, change display rotation and see that a notification
always appears

Committed: https://crrev.com/f60d6ea452282d53ef12de076c0a5436bae3ddb7
Cr-Commit-Position: refs/heads/master@{#424553}

[James Cook, 2016-10-06 00:20:47]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2016-10-06 00:21:05]

Description was changed from

==========
ash: Remove broken display notification suppression when settings is open

On Chrome OS we used to have code that suppressed showing a display change
notification (e.g. resolution changed) when the display settings UI was
visible. This broke when settings moved from being shown in a tab to being
shown in a window. We always show the notifications, and have been doing so
for several milestones now.
miletones now.

I spoke with PM tbuckley@ and he's OK with continuing to always show the
notifications. So I've deleted the code, effectively a manual revert of
http://crrev.com/208299

This simplifies ash::SystemTrayDelegate and removes one method I would have
to port to mojo for mustash.

BUG=246271,647412
TEST=ash_unittests, change display rotation and see that a notification
always appears
==========

to

==========
ash: Remove broken display notification suppression when settings is open

On Chrome OS we used to have code that suppressed showing a display change
notification (e.g. resolution changed) when the display settings UI was
visible. This broke when settings moved from being shown in a tab to being
shown in a window. We always show the notifications, and have been doing so
for several milestones now.

I spoke with PM tbuckley@ and he's OK with continuing to always show the
notifications. So I've deleted the code, effectively a manual revert of
http://crrev.com/208299

This simplifies ash::SystemTrayDelegate and removes one method I would have
to port to mojo for mustash.

BUG=246271,647412
TEST=ash_unittests, change display rotation and see that a notification
always appears
==========

[commit-bot: I haz the power, 2016-10-06 00:21:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-10-06 00:22:34]

Description was changed from

==========
ash: Remove broken display notification suppression when settings is open

On Chrome OS we used to have code that suppressed showing a display change
notification (e.g. resolution changed) when the display settings UI was
visible. This broke when settings moved from being shown in a tab to being
shown in a window. We always show the notifications, and have been doing so
for several milestones now.

I spoke with PM tbuckley@ and he's OK with continuing to always show the
notifications. So I've deleted the code, effectively a manual revert of
http://crrev.com/208299

This simplifies ash::SystemTrayDelegate and removes one method I would have
to port to mojo for mustash.

BUG=246271,647412
TEST=ash_unittests, change display rotation and see that a notification
always appears
==========

to

==========
ash: Remove broken display notification suppression when settings is open

On Chrome OS we used to have code that suppressed showing a display change
notification (e.g. resolution changed) when the display settings UI was
visible. This broke when settings moved from being shown in a tab to being
shown in a window. We always show the notifications, and have been doing so
for a long time.

I spoke with PM tbuckley@ and he's OK with always showing the notifications
I've deleted the code that was trying to suppress them, effectively doing a
manual revert of http://crrev.com/208299

This simplifies ash::SystemTrayDelegate and removes one method I would have
to port to mojo for mustash.

BUG=246271,647412
TEST=ash_unittests, change display rotation and see that a notification
always appears
==========

[James Cook, 2016-10-06 00:22:48]

jamescook@chromium.org changed reviewers:
+ oshima@chromium.org

[James Cook, 2016-10-06 00:22:48]

oshima, please take a look

[commit-bot: I haz the power, 2016-10-06 00:35:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 00:35:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2016-10-06 17:41:24]

Description was changed from

==========
ash: Remove broken display notification suppression when settings is open

On Chrome OS we used to have code that suppressed showing a display change
notification (e.g. resolution changed) when the display settings UI was
visible. This broke when settings moved from being shown in a tab to being
shown in a window. We always show the notifications, and have been doing so
for a long time.

I spoke with PM tbuckley@ and he's OK with always showing the notifications
I've deleted the code that was trying to suppress them, effectively doing a
manual revert of http://crrev.com/208299

This simplifies ash::SystemTrayDelegate and removes one method I would have
to port to mojo for mustash.

BUG=246271,647412
TEST=ash_unittests, change display rotation and see that a notification
always appears
==========

to

==========
ash: Remove broken display notification suppression when settings is open

On Chrome OS we used to have code that suppressed showing a display change
notification (e.g. resolution changed) when the display settings UI was
visible. This broke when settings moved from being shown in a tab to being
shown in a window. We always show the notifications, and have been doing so
for about 2 years.

I spoke with PM tbuckley@ and he's OK with always showing the notifications
I've deleted the code that was trying to suppress them, effectively doing a
manual revert of http://crrev.com/208299

This simplifies ash::SystemTrayDelegate and removes one method I would have
to port to mojo for mustash.

BUG=246271,647412
TEST=ash_unittests, change display rotation and see that a notification
always appears
==========

[James Cook, 2016-10-06 18:02:18]

Patchset #2 (id:20001) has been deleted

[James Cook, 2016-10-06 18:13:50]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-06 18:14:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 18:18:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 18:18:23]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[James Cook, 2016-10-10 17:02:51]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 17:03:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-10-10 17:03:45]

Ping oshima?

[commit-bot: I haz the power, 2016-10-10 17:36:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 17:36:32]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2016-10-10 21:51:46]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-10 21:52:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-10 22:19:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-10 22:19:33]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-10-11 17:19:00]

lgtm

https://codereview.chromium.org/2400553002/diff/100001/ash/wm/ash_native_curs...
File ash/wm/ash_native_cursor_manager_interactive_uitest.cc (right):

https://codereview.chromium.org/2400553002/diff/100001/ash/wm/ash_native_curs...
ash/wm/ash_native_cursor_manager_interactive_uitest.cc:82:
ScopedSuppressNotifications suppress_notifications;
can you file a bug with a stack?

[James Cook, 2016-10-11 17:35:01]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 17:35:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-10-11 18:01:04]

https://codereview.chromium.org/2400553002/diff/100001/ash/wm/ash_native_curs...
File ash/wm/ash_native_cursor_manager_interactive_uitest.cc (right):

https://codereview.chromium.org/2400553002/diff/100001/ash/wm/ash_native_curs...
ash/wm/ash_native_cursor_manager_interactive_uitest.cc:82:
ScopedSuppressNotifications suppress_notifications;
On 2016/10/11 17:19:00, oshima wrote:
> can you file a bug with a stack?

Added link to bug.

[commit-bot: I haz the power, 2016-10-11 18:04:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 18:04:48]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-10-11 18:45:39]

oshima, please take another look.

[James Cook, 2016-10-11 18:45:47]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 18:46:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 19:18:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 19:18:03]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[James Cook, 2016-10-11 19:22:48]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-11 19:23:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 20:23:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-11 20:23:18]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-10-11 20:50:34]

lgtm

https://codereview.chromium.org/2400553002/diff/180001/ash/system/chromeos/sc...
File ash/system/chromeos/screen_layout_observer.h (right):

https://codereview.chromium.org/2400553002/diff/180001/ash/system/chromeos/sc...
ash/system/chromeos/screen_layout_observer.h:32: // Allow tests to suppress
showing notifications.
nit: update the comment. (or clarify as it sounds confusing)
it's probably better to say the default is true (allowed) but false in unit
tests.

[James Cook, 2016-10-11 20:58:17]

Thanks for the reviews.

https://codereview.chromium.org/2400553002/diff/180001/ash/system/chromeos/sc...
File ash/system/chromeos/screen_layout_observer.h (right):

https://codereview.chromium.org/2400553002/diff/180001/ash/system/chromeos/sc...
ash/system/chromeos/screen_layout_observer.h:32: // Allow tests to suppress
showing notifications.
On 2016/10/11 20:50:34, oshima wrote:
> nit: update the comment. (or clarify as it sounds confusing)
> it's probably better to say the default is true (allowed) but false in unit
> tests.

Done.

[James Cook, 2016-10-11 20:58:24]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-10-11 20:58:25]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2400553002/#ps200001
(title: "fix comment")

[commit-bot: I haz the power, 2016-10-11 20:58:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-11 21:38:03]

Description was changed from

==========
ash: Remove broken display notification suppression when settings is open

On Chrome OS we used to have code that suppressed showing a display change
notification (e.g. resolution changed) when the display settings UI was
visible. This broke when settings moved from being shown in a tab to being
shown in a window. We always show the notifications, and have been doing so
for about 2 years.

I spoke with PM tbuckley@ and he's OK with always showing the notifications
I've deleted the code that was trying to suppress them, effectively doing a
manual revert of http://crrev.com/208299

This simplifies ash::SystemTrayDelegate and removes one method I would have
to port to mojo for mustash.

BUG=246271,647412
TEST=ash_unittests, change display rotation and see that a notification
always appears
==========

to

==========
ash: Remove broken display notification suppression when settings is open

On Chrome OS we used to have code that suppressed showing a display change
notification (e.g. resolution changed) when the display settings UI was
visible. This broke when settings moved from being shown in a tab to being
shown in a window. We always show the notifications, and have been doing so
for about 2 years.

I spoke with PM tbuckley@ and he's OK with always showing the notifications
I've deleted the code that was trying to suppress them, effectively doing a
manual revert of http://crrev.com/208299

This simplifies ash::SystemTrayDelegate and removes one method I would have
to port to mojo for mustash.

BUG=246271,647412
TEST=ash_unittests, change display rotation and see that a notification
always appears
==========

[commit-bot: I haz the power, 2016-10-11 21:38:05]

Committed patchset #10 (id:200001)

[commit-bot: I haz the power, 2016-10-11 21:39:44]

Description was changed from

==========
ash: Remove broken display notification suppression when settings is open

On Chrome OS we used to have code that suppressed showing a display change
notification (e.g. resolution changed) when the display settings UI was
visible. This broke when settings moved from being shown in a tab to being
shown in a window. We always show the notifications, and have been doing so
for about 2 years.

I spoke with PM tbuckley@ and he's OK with always showing the notifications
I've deleted the code that was trying to suppress them, effectively doing a
manual revert of http://crrev.com/208299

This simplifies ash::SystemTrayDelegate and removes one method I would have
to port to mojo for mustash.

BUG=246271,647412
TEST=ash_unittests, change display rotation and see that a notification
always appears
==========

to

==========
ash: Remove broken display notification suppression when settings is open

On Chrome OS we used to have code that suppressed showing a display change
notification (e.g. resolution changed) when the display settings UI was
visible. This broke when settings moved from being shown in a tab to being
shown in a window. We always show the notifications, and have been doing so
for about 2 years.

I spoke with PM tbuckley@ and he's OK with always showing the notifications
I've deleted the code that was trying to suppress them, effectively doing a
manual revert of http://crrev.com/208299

This simplifies ash::SystemTrayDelegate and removes one method I would have
to port to mojo for mustash.

BUG=246271,647412
TEST=ash_unittests, change display rotation and see that a notification
always appears

Committed: https://crrev.com/f60d6ea452282d53ef12de076c0a5436bae3ddb7
Cr-Commit-Position: refs/heads/master@{#424553}
==========

[commit-bot: I haz the power, 2016-10-11 21:39:45]

Patchset 10 (id:??) landed as
https://crrev.com/f60d6ea452282d53ef12de076c0a5436bae3ddb7
Cr-Commit-Position: refs/heads/master@{#424553}