Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: ash/system/web_notification/web_notification_tray_unittest.cc

Issue 2400553002: ash: Remove broken display notification suppression when settings is open (Closed)
Patch Set: fix comment Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/system/chromeos/screen_layout_observer_unittest.cc ('k') | ash/test/ash_test_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/system/web_notification/web_notification_tray_unittest.cc
diff --git a/ash/system/web_notification/web_notification_tray_unittest.cc b/ash/system/web_notification/web_notification_tray_unittest.cc
index 9d4c59051e4f0540992bf16d89a2b39f92e8ae20..89de383fffadb91a3e4b2212fdb66e19434df255 100644
--- a/ash/system/web_notification/web_notification_tray_unittest.cc
+++ b/ash/system/web_notification/web_notification_tray_unittest.cc
@@ -40,6 +40,10 @@
#include "ui/views/view.h"
#include "ui/views/widget/widget.h"
+#if defined(OS_CHROMEOS)
+#include "ash/system/chromeos/screen_layout_observer.h"
+#endif
+
namespace ash {
namespace {
@@ -269,10 +273,9 @@ TEST_P(WebNotificationTrayTest, PopupShownOnBothDisplays) {
if (!SupportsMultipleDisplays())
return;
- // Enables to appear the notification for display changes.
- test::TestSystemTrayDelegate* tray_delegate = GetSystemTrayDelegate();
- tray_delegate->set_should_show_display_notification(true);
-
+ Shell::GetInstance()
+ ->screen_layout_observer()
+ ->set_show_notifications_for_testing(true);
UpdateDisplay("400x400,200x200");
// UpdateDisplay() creates the display notifications, so popup is visible.
EXPECT_TRUE(GetTray()->IsPopupVisible());
« no previous file with comments | « ash/system/chromeos/screen_layout_observer_unittest.cc ('k') | ash/test/ash_test_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698