Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: chrome/browser/ui/translate/translate_bubble_factory.h

Issue 2400503002: [Translate] Integrate TranslateEventProto UMA logging into TranslateManager. (Closed)
Patch Set: fix trybots Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/translate/translate_bubble_factory.h
diff --git a/chrome/browser/ui/translate/translate_bubble_factory.h b/chrome/browser/ui/translate/translate_bubble_factory.h
index 16bf68151e9b0ad703689bc04dcc44356e7eb0da..5efb6f00ac5decde1502832bbd2e9a9b8a9f19fe 100644
--- a/chrome/browser/ui/translate/translate_bubble_factory.h
+++ b/chrome/browser/ui/translate/translate_bubble_factory.h
@@ -10,6 +10,7 @@
#include "components/translate/core/common/translate_errors.h"
class BrowserWindow;
+enum class ShowTranslateBubbleResult;
namespace content {
class WebContents;
@@ -22,10 +23,11 @@ class TranslateBubbleFactory {
// Shows the translate bubble. The behavior depends on the current factory's
// implementation.
- static void Show(BrowserWindow* window,
- content::WebContents* web_contents,
- translate::TranslateStep step,
- translate::TranslateErrors::Type error_type);
+ static ShowTranslateBubbleResult Show(
+ BrowserWindow* window,
+ content::WebContents* web_contents,
+ translate::TranslateStep step,
+ translate::TranslateErrors::Type error_type);
// Sets the factory to change the behavior how to show the bubble.
// TranslateBubbleFactory doesn't take the ownership of |factory|.
@@ -33,7 +35,7 @@ class TranslateBubbleFactory {
protected:
// Shows the translate bubble.
- virtual void ShowImplementation(
+ virtual ShowTranslateBubbleResult ShowImplementation(
BrowserWindow* window,
content::WebContents* web_contents,
translate::TranslateStep step,
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/translate/translate_bubble_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698