Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6031)

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa.mm

Issue 2400503002: [Translate] Integrate TranslateEventProto UMA logging into TranslateManager. (Closed)
Patch Set: fix trybots Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_cocoa.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa.mm b/chrome/browser/ui/cocoa/browser_window_cocoa.mm
index fe5eb1f68b03ecee624fecdacf7c5d4f71ca41c2..5dfb6809a8e89b02d2fe4a10822ef313cbedeec3 100644
--- a/chrome/browser/ui/cocoa/browser_window_cocoa.mm
+++ b/chrome/browser/ui/cocoa/browser_window_cocoa.mm
@@ -619,7 +619,7 @@ autofill::SaveCardBubbleView* BrowserWindowCocoa::ShowSaveCreditCardBubble(
return new autofill::SaveCardBubbleViewBridge(controller, controller_);
}
-void BrowserWindowCocoa::ShowTranslateBubble(
+ShowTranslateBubbleResult BrowserWindowCocoa::ShowTranslateBubble(
content::WebContents* contents,
translate::TranslateStep step,
translate::TranslateErrors::Type error_type,
@@ -633,6 +633,8 @@ void BrowserWindowCocoa::ShowTranslateBubble(
[controller_ showTranslateBubbleForWebContents:contents
step:step
errorType:error_type];
+
+ return ShowTranslateBubbleResult::SUCCESS;
}
#if BUILDFLAG(ENABLE_ONE_CLICK_SIGNIN)
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.h ('k') | chrome/browser/ui/translate/translate_bubble_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698