Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2867)

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 2400503002: [Translate] Integrate TranslateEventProto UMA logging into TranslateManager. (Closed)
Patch Set: fix trybots Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/browser_commands.cc
diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc
index 8bc6cdd5f3ae3afdc8d42e37c23a84c9a1aaa2e0..3496255179e38adcd110b9bc79edf88d8ee24ea7 100644
--- a/chrome/browser/ui/browser_commands.cc
+++ b/chrome/browser/ui/browser_commands.cc
@@ -51,6 +51,7 @@
#include "chrome/browser/ui/tab_contents/core_tab_helper.h"
#include "chrome/browser/ui/tab_dialogs.h"
#include "chrome/browser/ui/tabs/tab_strip_model.h"
+#include "chrome/browser/ui/translate/translate_bubble_view_state_transition.h"
#include "chrome/browser/upgrade_detector.h"
#include "chrome/common/content_restriction.h"
#include "chrome/common/features.h"
@@ -118,9 +119,37 @@
#endif
namespace {
+
const char kOsOverrideForTabletSite[] = "Linux; Android 4.0.3";
+
+translate::TranslateBubbleUiEvent TranslateBubbleResultToUiEvent(
+ ShowTranslateBubbleResult result) {
+ switch (result) {
+ default:
+ NOTREACHED();
+ // Fall through.
+ case ShowTranslateBubbleResult::SUCCESS:
+ return translate::TranslateBubbleUiEvent::BUBBLE_SHOWN;
+ case ShowTranslateBubbleResult::BROWSER_WINDOW_NOT_VALID:
+ return translate::TranslateBubbleUiEvent::
+ BUBBLE_NOT_SHOWN_WINDOW_NOT_VALID;
+ case ShowTranslateBubbleResult::BROWSER_WINDOW_MINIMIZED:
+ return translate::TranslateBubbleUiEvent::
+ BUBBLE_NOT_SHOWN_WINDOW_MINIMIZED;
+ case ShowTranslateBubbleResult::BROWSER_WINDOW_NOT_ACTIVE:
+ return translate::TranslateBubbleUiEvent::
+ BUBBLE_NOT_SHOWN_WINDOW_NOT_ACTIVE;
+ case ShowTranslateBubbleResult::WEB_CONTENTS_NOT_ACTIVE:
+ return translate::TranslateBubbleUiEvent::
+ BUBBLE_NOT_SHOWN_WEB_CONTENTS_NOT_ACTIVE;
+ case ShowTranslateBubbleResult::EDITABLE_FIELD_IS_ACTIVE:
+ return translate::TranslateBubbleUiEvent::
+ BUBBLE_NOT_SHOWN_EDITABLE_FIELD_IS_ACTIVE;
+ }
}
+} // namespace
+
using base::UserMetricsAction;
using bookmarks::BookmarkModel;
using content::NavigationController;
@@ -828,8 +857,10 @@ void Translate(Browser* browser) {
else if (chrome_translate_client->GetLanguageState().IsPageTranslated())
step = translate::TRANSLATE_STEP_AFTER_TRANSLATE;
}
- browser->window()->ShowTranslateBubble(
+ ShowTranslateBubbleResult result = browser->window()->ShowTranslateBubble(
web_contents, step, translate::TranslateErrors::NONE, true);
+ if (result != ShowTranslateBubbleResult::SUCCESS)
+ translate::ReportUiAction(TranslateBubbleResultToUiEvent(result));
}
void ManagePasswordsForPage(Browser* browser) {
« no previous file with comments | « chrome/browser/translate/translate_manager_render_view_host_unittest.cc ('k') | chrome/browser/ui/browser_window.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698