Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: chrome/browser/translate/translate_manager_render_view_host_unittest.cc

Issue 2400503002: [Translate] Integrate TranslateEventProto UMA logging into TranslateManager. (Closed)
Patch Set: fix trybots Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/translate/chrome_translate_client.cc ('k') | chrome/browser/ui/browser_commands.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/translate/translate_manager_render_view_host_unittest.cc
diff --git a/chrome/browser/translate/translate_manager_render_view_host_unittest.cc b/chrome/browser/translate/translate_manager_render_view_host_unittest.cc
index 307192b4bba0cc69baa82b3f9fd260983d5eaaf4..c929fcada113d3ec8037d6bdcadc174c75a13168 100644
--- a/chrome/browser/translate/translate_manager_render_view_host_unittest.cc
+++ b/chrome/browser/translate/translate_manager_render_view_host_unittest.cc
@@ -23,6 +23,7 @@
#include "chrome/browser/renderer_context_menu/render_view_context_menu_test_util.h"
#include "chrome/browser/translate/chrome_translate_client.h"
#include "chrome/browser/translate/translate_service.h"
+#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/translate/translate_bubble_factory.h"
#include "chrome/browser/ui/translate/translate_bubble_model.h"
#include "chrome/browser/ui/translate/translate_bubble_model_impl.h"
@@ -72,7 +73,7 @@ class MockTranslateBubbleFactory : public TranslateBubbleFactory {
public:
MockTranslateBubbleFactory() {}
- void ShowImplementation(
+ ShowTranslateBubbleResult ShowImplementation(
BrowserWindow* window,
content::WebContents* web_contents,
translate::TranslateStep step,
@@ -80,7 +81,7 @@ class MockTranslateBubbleFactory : public TranslateBubbleFactory {
if (model_) {
model_->SetViewState(
TranslateBubbleModelImpl::TranslateStepToViewState(step));
- return;
+ return ShowTranslateBubbleResult::SUCCESS;
}
ChromeTranslateClient* chrome_translate_client =
@@ -96,6 +97,7 @@ class MockTranslateBubbleFactory : public TranslateBubbleFactory {
chrome_translate_client->GetTranslateManager()->GetWeakPtr(),
source_language, target_language));
model_.reset(new TranslateBubbleModelImpl(step, std::move(ui_delegate)));
+ return ShowTranslateBubbleResult::SUCCESS;
}
bool DismissBubble() {
« no previous file with comments | « chrome/browser/translate/chrome_translate_client.cc ('k') | chrome/browser/ui/browser_commands.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698