Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2400373002: Fix GpuRasterization.BlueBox expectation. (Closed)

Created:
4 years, 2 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 2 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, Jamie Madill
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix GpuRasterization.BlueBox expectation. Strengthen logic and add unit test to prevent accidental string/int confusion. BUG=653538 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=zmo@chromium.org Committed: https://crrev.com/2fc6108a69d4566e51b994d56de6574257330684 Cr-Commit-Position: refs/heads/master@{#424045}

Patch Set 1 #

Patch Set 2 : Slight cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M content/test/gpu/gpu_tests/gpu_rasterization_expectations.py View 1 chunk +1 line, -1 line 0 comments Download
M content/test/gpu/gpu_tests/gpu_test_expectations.py View 1 1 chunk +16 lines, -1 line 0 comments Download
M content/test/gpu/gpu_tests/gpu_test_expectations_unittest.py View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Ken Russell (switch to Gerrit)
FYI. CQ'ing TBR'd.
4 years, 2 months ago (2016-10-07 23:57:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400373002/20001
4 years, 2 months ago (2016-10-07 23:58:14 UTC) #6
Jamie Madill
Thanks for figuring this out Ken!
4 years, 2 months ago (2016-10-08 00:18:54 UTC) #8
Ken Russell (switch to Gerrit)
On 2016/10/08 00:18:54, Jamie Madill wrote: > Thanks for figuring this out Ken! You're welcome! ...
4 years, 2 months ago (2016-10-08 02:07:11 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-08 02:10:47 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-10-08 02:13:33 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2fc6108a69d4566e51b994d56de6574257330684
Cr-Commit-Position: refs/heads/master@{#424045}

Powered by Google App Engine
This is Rietveld 408576698