Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2330)

Unified Diff: content/test/gpu/gpu_tests/gpu_test_expectations_unittest.py

Issue 2400373002: Fix GpuRasterization.BlueBox expectation. (Closed)
Patch Set: Slight cleanup. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/gpu/gpu_tests/gpu_test_expectations.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/gpu/gpu_tests/gpu_test_expectations_unittest.py
diff --git a/content/test/gpu/gpu_tests/gpu_test_expectations_unittest.py b/content/test/gpu/gpu_tests/gpu_test_expectations_unittest.py
index 1cc5267afbf2b58c79c41248c434c7040f6b0362..bccc8bc2a7334f319fe24679154744b38b100835 100644
--- a/content/test/gpu/gpu_tests/gpu_test_expectations_unittest.py
+++ b/content/test/gpu/gpu_tests/gpu_test_expectations_unittest.py
@@ -71,6 +71,10 @@ class SampleTestExpectations(gpu_test_expectations.GpuTestExpectations):
self.Flaky('test8.html', ['win'], bug=123, max_num_retries=6)
self.Flaky('wildcardtest*.html', ['win'], bug=123, max_num_retries=7)
+class InvalidDeviceIDExpectation(gpu_test_expectations.GpuTestExpectations):
+ def SetExpectations(self):
+ self.Fail('test1.html', [('amd', '0x6613')], bug=123)
+
class GpuTestExpectationsTest(unittest.TestCase):
def setUp(self):
self.expectations = SampleTestExpectations()
@@ -198,3 +202,8 @@ class GpuTestExpectationsTest(unittest.TestCase):
self.assertEquals(7, self.getRetriesForPage(page2, StubPlatform('win')))
self.assertExpectationEquals('pass', page2, StubPlatform('mac'))
self.assertEquals(0, self.getRetriesForPage(page2, StubPlatform('mac')))
+
+ # Test that device IDs are checked to be integers.
+ def testDeviceIDIsInteger(self):
+ with self.assertRaises(ValueError):
+ InvalidDeviceIDExpectation()
« no previous file with comments | « content/test/gpu/gpu_tests/gpu_test_expectations.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698