Don't show download button for HLS streams

third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

Index: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
index 022370bfdd79ba204e54fd57a969e6312dfd4761..ff3f67e5300d907ff893c8a2cea5c7220890e2ea 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
@@ -673,6 +673,11 @@ bool MediaControlDownloadButtonElement::shouldDisplayDownloadButton() {
   if (HTMLMediaSource::lookup(url))
     return false;
 
+  // HLS stream shouldn't have a download button. Keep the same logic as in
+  // media_codec_util.h.
+  if (url.getString().contains("m3u8"))

[mlamouri (slow - plz ping), 2016/10/08 09:57:54]

Can you make this a static method on HTMLMediaElement like isMediaStreamURL:
isHLSURL() so we can re-use it.

It would be great if we could make the check similar to
https://cs.chromium.org/chromium/src/media/base/android/media_codec_util.cc?l...

[qinmin, 2016/10/10 19:17:42]

Done. IsHLSURL is more correct compared to IsHLSPath, according to UMA

+    return false;
+
   return true;
 }