Don't show download button for HLS streams

third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

 /*
  * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 655 matching lines @@
     return false;
 
   // MediaStream can't be downloaded.
   if (HTMLMediaElement::isMediaStreamURL(url.getString()))
     return false;
 
   // MediaSource can't be downloaded.
   if (HTMLMediaSource::lookup(url))
     return false;
 
+  // HLS stream shouldn't have a download button. Keep the same logic as in
+  // media_codec_util.h.
+  if (url.getString().contains("m3u8"))

[mlamouri (slow - plz ping), 2016/10/08 09:57:54]

Can you make this a static method on HTMLMediaElement like isMediaStreamURL:
isHLSURL() so we can re-use it.

It would be great if we could make the check similar to
https://cs.chromium.org/chromium/src/media/base/android/media_codec_util.cc?l...

[qinmin, 2016/10/10 19:17:42]

Done. IsHLSURL is more correct compared to IsHLSPath, according to UMA

+    return false;
+
   return true;
 }
 
 void MediaControlDownloadButtonElement::defaultEventHandler(Event* event) {
   const KURL& url = mediaElement().currentSrc();
   if (event->type() == EventTypeNames::click &&
       !(url.isNull() || url.isEmpty())) {
     Platform::current()->recordAction(
         UserMetricsAction("Media.Controls.Download"));
     if (!m_anchor) {
@@ skipping 339 matching lines @@
 MediaControlCurrentTimeDisplayElement*
 MediaControlCurrentTimeDisplayElement::create(MediaControls& mediaControls) {
   MediaControlCurrentTimeDisplayElement* element =
       new MediaControlCurrentTimeDisplayElement(mediaControls);
   element->setShadowPseudoId(
       AtomicString("-webkit-media-controls-current-time-display"));
   return element;
 }
 
 }  // namespace blink