Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/quic/chromium/crypto/proof_verifier_chromium.cc

Issue 2400183002: Cleanup: More accurate output parameter type for CTVerifier (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/multi_log_ct_verifier_unittest.cc ('k') | net/quic/chromium/crypto/proof_verifier_chromium_test.cc » ('j') | net/socket/ssl_client_socket_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/crypto/proof_verifier_chromium.cc
diff --git a/net/quic/chromium/crypto/proof_verifier_chromium.cc b/net/quic/chromium/crypto/proof_verifier_chromium.cc
index 5195d74b5a002b38ff3770b65d52c4871e5d4d02..5c31b26f0e34dd489606568859b3bae59e4d504e 100644
--- a/net/quic/chromium/crypto/proof_verifier_chromium.cc
+++ b/net/quic/chromium/crypto/proof_verifier_chromium.cc
@@ -230,9 +230,9 @@ QuicAsyncStatus ProofVerifierChromium::Job::VerifyProof(
// Note that this is a completely synchronous operation: The CT Log Verifier
// gets all the data it needs for SCT verification and does not do any
// external communication.
- cert_transparency_verifier_->Verify(cert_.get(), std::string(), cert_sct,
- &verify_details_->ct_verify_result,
- net_log_);
+ cert_transparency_verifier_->Verify(
+ cert_.get(), std::string(), cert_sct,
+ &(verify_details_->ct_verify_result.scts), net_log_);
Ryan Sleevi 2016/10/07 14:05:28 Are the parens necessary here?
Eran Messeri 2016/10/10 13:14:09 Done, removed.
}
// We call VerifySignature first to avoid copying of server_config and
« no previous file with comments | « net/cert/multi_log_ct_verifier_unittest.cc ('k') | net/quic/chromium/crypto/proof_verifier_chromium_test.cc » ('j') | net/socket/ssl_client_socket_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698