Cleanup: More accurate output parameter type for CTVerifier

net/quic/chromium/crypto/proof_verifier_chromium.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/quic/chromium/crypto/proof_verifier_chromium.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 212 matching lines @@
   verify_details_.reset(new ProofVerifyDetailsChromium);
 
   // Converts |certs| to |cert_|.
   if (!GetX509Certificate(certs, error_details, verify_details))
     return QUIC_FAILURE;
 
   if (!cert_sct.empty()) {
     // Note that this is a completely synchronous operation: The CT Log Verifier
     // gets all the data it needs for SCT verification and does not do any
     // external communication.
-    cert_transparency_verifier_->Verify(cert_.get(), std::string(), cert_sct,
-                                        &verify_details_->ct_verify_result,
-                                        net_log_);
+    cert_transparency_verifier_->Verify(
+        cert_.get(), std::string(), cert_sct,
+        &(verify_details_->ct_verify_result.scts), net_log_);

[Ryan Sleevi, 2016/10/07 14:05:28]

Are the parens necessary here?

[Eran Messeri, 2016/10/10 13:14:09]

Done, removed.

   }
 
   // We call VerifySignature first to avoid copying of server_config and
   // signature.
   if (!signature.empty() &&
       !VerifySignature(server_config, quic_version, chlo_hash, signature,
                        certs[0])) {
     *error_details = "Failed to verify signature of server config";
     DLOG(WARNING) << *error_details;
     verify_details_->cert_verify_result.cert_status = CERT_STATUS_INVALID;
@@ skipping 368 matching lines @@
     active_jobs_.insert(job.release());
   return status;
 }
 
 void ProofVerifierChromium::OnJobComplete(Job* job) {
   active_jobs_.erase(job);
   delete job;
 }
 
 }  // namespace net