Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 2400063002: Don't clip contain:paint when requested to ignore clip (Closed)

Created:
4 years, 2 months ago by Xianzhu
Modified:
4 years, 2 months ago
Reviewers:
chrishtr
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't clip contain:paint when requested to ignore clip This fixes another place that previously forced clip for contain:paint, causing corrupted painting in nested contain:paint containers. Other places were fixed in https://codereview.chromium.org/1985933002. BUG=648091 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/56d8f0dc244d264c3a99d13b6b06f143a81c06d2 Cr-Commit-Position: refs/heads/master@{#423788}

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -16 lines) Patch
M third_party/WebKit/Source/core/paint/PaintLayerClipper.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp View 1 2 5 chunks +13 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp View 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
Xianzhu
It basically changed: if ((hasOverflowClip && shouldRespectOverflowClip) || containsPaint) to if ((hasOverflowClip || containsPaint) && ...
4 years, 2 months ago (2016-10-06 23:50:16 UTC) #9
chrishtr
lgtm
4 years, 2 months ago (2016-10-07 01:24:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2400063002/40001
4 years, 2 months ago (2016-10-07 02:40:30 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-07 02:45:28 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-07 02:47:19 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/56d8f0dc244d264c3a99d13b6b06f143a81c06d2
Cr-Commit-Position: refs/heads/master@{#423788}

Powered by Google App Engine
This is Rietveld 408576698