Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1985933002: Don't clip composited scrolling contain:paint (Closed)

Created:
4 years, 7 months ago by Xianzhu
Modified:
4 years, 7 months ago
Reviewers:
chrishtr, eae
CC:
chromium-reviews, blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't clip composited scrolling contain:paint BUG=606342 TEST=fast/css/containment/contain-paint-composited-scroll.html Committed: https://crrev.com/580ba30eac72aa1c0bf2b93d31a0843211deba92 Cr-Commit-Position: refs/heads/master@{#394213}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -4 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/containment/contain-paint-composited-scroll.html View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css/containment/contain-paint-composited-scroll-expected.html View 1 2 1 chunk +30 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxClipper.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Xianzhu
4 years, 7 months ago (2016-05-17 00:17:29 UTC) #3
eae
Awesome, thank you! LGTM
4 years, 7 months ago (2016-05-17 00:18:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985933002/20001
4 years, 7 months ago (2016-05-17 00:19:08 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/228682)
4 years, 7 months ago (2016-05-17 01:44:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1985933002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1985933002/40001
4 years, 7 months ago (2016-05-17 16:29:31 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-17 20:24:22 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 20:28:11 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/580ba30eac72aa1c0bf2b93d31a0843211deba92
Cr-Commit-Position: refs/heads/master@{#394213}

Powered by Google App Engine
This is Rietveld 408576698