Use CBE for firefighter

Use CBE for firefighter

BUG=chromium:651975
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/4bed9fcc4b459147f05107061d741a9b3ca8d56b

[martiniss, 2016-10-06 22:56:31]

martiniss@chromium.org changed reviewers:
+ dtu@chromium.org

[martiniss, 2016-10-06 22:56:33]

PTAL

Not sure if there are tests or anything....

https://codereview.chromium.org/2400053002/diff/1/firefighter/update/common/b...
File firefighter/update/common/buildbot/builds.py (left):

https://codereview.chromium.org/2400053002/diff/1/firefighter/update/common/b...
firefighter/update/common/buildbot/builds.py:70: except (ValueError,
urlfetch.ResponseTooLargeError):
I removed this logic because CBE doesn't support the select logic that you're
using here. How important is it?

[dtu, 2016-10-07 17:10:55]

lgtm. There are other calls to BuildUrl in Firefighter too, are those not
supported yet?

https://codereview.chromium.org/2400053002/diff/1/firefighter/update/common/b...
File firefighter/update/common/buildbot/builds.py (left):

https://codereview.chromium.org/2400053002/diff/1/firefighter/update/common/b...
firefighter/update/common/buildbot/builds.py:70: except (ValueError,
urlfetch.ResponseTooLargeError):
On 2016/10/06 22:56:33, martiniss wrote:
> I removed this logic because CBE doesn't support the select logic that you're
> using here. How important is it?

Yeah, that's fine. It was only because BuildBot was so slow.

[martiniss, 2016-10-07 18:28:47]

On 2016/10/07 at 17:10:55, dtu wrote:
> lgtm. There are other calls to BuildUrl in Firefighter too, are those not
supported yet?

I wanted to do a simple change first; firefighter does enough fancy json calls
that I just wanted to start with something I knew CBE supported.

I can switch all the other calls over to use CBE/milo once this lands and works
in prod.

> 
>
https://codereview.chromium.org/2400053002/diff/1/firefighter/update/common/b...
> File firefighter/update/common/buildbot/builds.py (left):
> 
>
https://codereview.chromium.org/2400053002/diff/1/firefighter/update/common/b...
> firefighter/update/common/buildbot/builds.py:70: except (ValueError,
urlfetch.ResponseTooLargeError):
> On 2016/10/06 22:56:33, martiniss wrote:
> > I removed this logic because CBE doesn't support the select logic that
you're
> > using here. How important is it?
> 
> Yeah, that's fine. It was only because BuildBot was so slow.



Can I get access to the firefighter cloud project?

[martiniss, 2016-10-07 18:28:49]

The CQ bit was checked by martiniss@chromium.org

[commit-bot: I haz the power, 2016-10-07 18:28:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 18:31:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-07 18:31:06]

Try jobs failed on following builders:
  Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Pr...)

[martiniss, 2016-10-07 18:47:14]

Description was changed from

==========
Use CBE for firefighter

BUG=chromium:#651975
==========

to

==========
Use CBE for firefighter

BUG=chromium:651975
==========

[martiniss, 2016-10-07 18:47:21]

The CQ bit was checked by martiniss@chromium.org

[commit-bot: I haz the power, 2016-10-07 18:47:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 18:48:45]

Description was changed from

==========
Use CBE for firefighter

BUG=chromium:651975
==========

to

==========
Use CBE for firefighter

BUG=chromium:651975

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-10-07 18:48:46]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[dtu, 2016-10-11 22:46:31]

On 2016/10/07 18:28:47, martiniss wrote:
> On 2016/10/07 at 17:10:55, dtu wrote:
> > lgtm. There are other calls to BuildUrl in Firefighter too, are those not
> supported yet?
> 
> I wanted to do a simple change first; firefighter does enough fancy json calls
> that I just wanted to start with something I knew CBE supported.
> 
> I can switch all the other calls over to use CBE/milo once this lands and
works
> in prod.
> 
> > 
> >
>
https://codereview.chromium.org/2400053002/diff/1/firefighter/update/common/b...
> > File firefighter/update/common/buildbot/builds.py (left):
> > 
> >
>
https://codereview.chromium.org/2400053002/diff/1/firefighter/update/common/b...
> > firefighter/update/common/buildbot/builds.py:70: except (ValueError,
> urlfetch.ResponseTooLargeError):
> > On 2016/10/06 22:56:33, martiniss wrote:
> > > I removed this logic because CBE doesn't support the select logic that
> you're
> > > using here. How important is it?
> > 
> > Yeah, that's fine. It was only because BuildBot was so slow.
> 
> 
> 
> Can I get access to the firefighter cloud project?

Done.

[martiniss, 2016-10-12 01:12:02]

On 2016/10/11 at 22:46:31, dtu wrote:
> On 2016/10/07 18:28:47, martiniss wrote:
> > On 2016/10/07 at 17:10:55, dtu wrote:
> > > lgtm. There are other calls to BuildUrl in Firefighter too, are those not
> > supported yet?
> > 
> > I wanted to do a simple change first; firefighter does enough fancy json
calls
> > that I just wanted to start with something I knew CBE supported.
> > 
> > I can switch all the other calls over to use CBE/milo once this lands and
works
> > in prod.
> > 
> > > 
> > >
> >
https://codereview.chromium.org/2400053002/diff/1/firefighter/update/common/b...
> > > File firefighter/update/common/buildbot/builds.py (left):
> > > 
> > >
> >
https://codereview.chromium.org/2400053002/diff/1/firefighter/update/common/b...
> > > firefighter/update/common/buildbot/builds.py:70: except (ValueError,
> > urlfetch.ResponseTooLargeError):
> > > On 2016/10/06 22:56:33, martiniss wrote:
> > > > I removed this logic because CBE doesn't support the select logic that
> > you're
> > > > using here. How important is it?
> > > 
> > > Yeah, that's fine. It was only because BuildBot was so slow.
> > 
> > 
> > 
> > Can I get access to the firefighter cloud project?
> 
> Done.

Deployed!