Use CBE for firefighter

firefighter/update/common/buildbot/builds.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import urllib
 
 from google.appengine.api import urlfetch
 
 from common.buildbot import build
@@ skipping 42 matching lines @@
     Raises:
       ValueError: A build number is invalid.
     """
     if not build_numbers:
       return
 
     for build_number in build_numbers:
       if build_number < 0:
         raise ValueError('Invalid build number: %d' % build_number)
 
-    build_query = urllib.urlencode(
-        [('select', build_number) for build_number in build_numbers])
-    url = 'json/builders/%s/builds/?%s' % (
-        urllib.quote(self._builder_name), build_query)
-    url = network.BuildUrl(self._master_name, url)
-    try:
-      builds = network.FetchData(url).values()
-    except (ValueError, urlfetch.ResponseTooLargeError):

[martiniss, 2016/10/06 22:56:33]

I removed this logic because CBE doesn't support the select logic that you're
using here. How important is it?

[dtu, 2016/10/07 17:10:55]

Yeah, that's fine. It was only because BuildBot was so slow.

-      # The JSON decode failed, or the data was too large.
-      # Try downloading the builds individually instead.
-      builds = []
-      for build_number in build_numbers:
-        url = 'json/builders/%s/builds/%d' % (
-            urllib.quote(self._builder_name), build_number)
-        url = network.BuildUrl(self._master_name, url)
-        try:
-          builds.append(network.FetchData(url))
-        except (ValueError, urlfetch.ResponseTooLargeError):
-          logging.warning('Unable to fetch %s build %d',
-                          self._master_name, build_number)
-          continue
+    builds = []
+    for build_number in build_numbers:
+      url = 'json/builders/%s/builds/%d' % (
+          urllib.quote(self._builder_name), build_number)
+      url = network.BuildUrl(self._master_name, url, use_cbe=True)
+      try:
+        builds.append(network.FetchData(url))
+      except (ValueError, urlfetch.ResponseTooLargeError):
+        logging.warning('Unable to fetch %s/%s build %d',
+                        self._master_name, self._builder_name, build_number)
+        continue
 
     for build_data in builds:
       if 'error' in build_data:
         continue
       yield build.Build(build_data, self._url)