Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Unified Diff: chrome/browser/resources/settings/device_page/display_layout.js

Issue 2400043004: MD Settings: Cleanup, remove obsolete dependencies. (Closed)
Patch Set: No diff Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/device_page/display_layout.js
diff --git a/chrome/browser/resources/settings/device_page/display_layout.js b/chrome/browser/resources/settings/device_page/display_layout.js
index eb1931f825f06cf0ef616bb92b173db4a1ca4043..db8bb3f44cdad0e3b6a4b97727645e17a870bfd8 100644
--- a/chrome/browser/resources/settings/device_page/display_layout.js
+++ b/chrome/browser/resources/settings/device_page/display_layout.js
@@ -179,12 +179,13 @@ Polymer({
/**
* @param {!{model: !{item: !chrome.system.display.DisplayUnitInfo},
- * target: !PaperButtonElement}} e
+ * target: !HTMLDivElement}} e
* @private
*/
onSelectDisplayTap_: function(e) {
this.fire('select-display', e.model.item.id);
// Force active in case the selected display was clicked.
+ // TODO(dpapad): Ask @stevenjb, why are we setting 'active' on a div?
e.target.active = true;
},
@@ -192,7 +193,7 @@ Polymer({
* @param {string} id
* @param {?DragPosition} amount
*/
- onDrag_(id, amount) {
+ onDrag_: function(id, amount) {
id = id.substr(1); // Skip prefix
var newBounds;

Powered by Google App Engine
This is Rietveld 408576698