Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: net/quic/core/crypto/p256_key_exchange.h

Issue 2400033005: Use BoringSSL scopers in //net. (Closed)
Patch Set: avoid some unnecessary refcount-bumping Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/core/crypto/p256_key_exchange.h
diff --git a/net/quic/core/crypto/p256_key_exchange.h b/net/quic/core/crypto/p256_key_exchange.h
index e6b32a2b771676ba6f3e2ae11c6870433d3a1aae..f244db96876eb27f04eadd3aa69f7e3c330a91e2 100644
--- a/net/quic/core/crypto/p256_key_exchange.h
+++ b/net/quic/core/crypto/p256_key_exchange.h
@@ -5,6 +5,7 @@
#ifndef NET_QUIC_CRYPTO_P256_KEY_EXCHANGE_H_
#define NET_QUIC_CRYPTO_P256_KEY_EXCHANGE_H_
+#include <openssl/base.h>
#include <stdint.h>
#include <memory>
@@ -13,7 +14,6 @@
#include "base/macros.h"
#include "base/strings/string_piece.h"
#include "crypto/openssl_util.h"
-#include "crypto/scoped_openssl_types.h"
#include "net/base/net_export.h"
#include "net/quic/core/crypto/key_exchange.h"
@@ -58,7 +58,7 @@ class NET_EXPORT_PRIVATE P256KeyExchange : public KeyExchange {
// |public_key| consists of |kUncompressedP256PointBytes| bytes.
P256KeyExchange(EC_KEY* private_key, const uint8_t* public_key);
eroman 2016/10/10 22:45:55 side-comment: based on this description sounds lik
davidben 2016/10/10 23:24:40 You're right. Fixed.
- crypto::ScopedEC_KEY private_key_;
+ bssl::UniquePtr<EC_KEY> private_key_;
// The public key stored as an uncompressed P-256 point.
uint8_t public_key_[kUncompressedP256PointBytes];

Powered by Google App Engine
This is Rietveld 408576698