Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 2399983003: cc: Make OutputSurface::Reshape abstract (Closed)

Created:
4 years, 2 months ago by danakj
Modified:
4 years, 2 months ago
CC:
android-webview-reviews_chromium.org, cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, darin-cc_chromium.org, jam, jbauman+watch_chromium.org, kalyank, kylechar, mlamouri+watch-content_chromium.org, piman+watch_chromium.org, rjkroege, sievers+watch_chromium.org, Ian Vollick
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Make OutputSurface::Reshape abstract DirectRenderer will cache the values given to Reshape and only call it when things change. TBR=dtrainor R=enne@chromium.org BUG=606056 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/70ffc43ceda0ffba0edf7ea136567af5bed5c819 Cr-Commit-Position: refs/heads/master@{#424255}

Patch Set 1 #

Patch Set 2 : reshapeabstract: softwareoutputdevice #

Patch Set 3 : reshapeabstract: . #

Patch Set 4 : reshapeabstract: ozone #

Patch Set 5 : reshapeabstract: . #

Patch Set 6 : reshapeabstract: blimp #

Patch Set 7 : reshapeabstract: blimppp #

Patch Set 8 : reshapeabstract: ctut #

Patch Set 9 : reshapeabstract: . #

Patch Set 10 : reshapeabstract: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -150 lines) Patch
M android_webview/browser/parent_output_surface.cc View 1 chunk +1 line, -4 lines 0 comments Download
M blimp/client/support/compositor/blimp_embedder_compositor.cc View 1 2 3 4 5 6 1 chunk +7 lines, -0 lines 0 comments Download
M cc/output/direct_renderer.h View 4 chunks +11 lines, -3 lines 0 comments Download
M cc/output/direct_renderer.cc View 2 chunks +17 lines, -8 lines 0 comments Download
M cc/output/gl_renderer.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/output/gl_renderer.cc View 7 chunks +15 lines, -12 lines 0 comments Download
M cc/output/gl_renderer_unittest.cc View 2 chunks +2 lines, -19 lines 0 comments Download
M cc/output/output_surface.h View 3 chunks +2 lines, -11 lines 0 comments Download
M cc/output/output_surface.cc View 1 chunk +0 lines, -20 lines 0 comments Download
M cc/output/output_surface_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/output/overlay_unittest.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M cc/output/software_output_device.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M cc/output/software_output_device.cc View 1 1 chunk +2 lines, -6 lines 0 comments Download
M cc/test/fake_output_surface.h View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/test/fake_output_surface.cc View 1 2 3 4 1 chunk +18 lines, -2 lines 0 comments Download
M cc/test/pixel_test_output_surface.h View 2 chunks +2 lines, -6 lines 0 comments Download
M cc/test/pixel_test_output_surface.cc View 1 2 3 4 1 chunk +7 lines, -4 lines 0 comments Download
M content/browser/compositor/gpu_browser_compositor_output_surface.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/compositor/gpu_browser_compositor_output_surface.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/compositor/gpu_surfaceless_browser_compositor_output_surface.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M content/browser/compositor/offscreen_browser_compositor_output_surface.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/compositor/offscreen_browser_compositor_output_surface.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M content/browser/compositor/reflector_impl_unittest.cc View 1 2 3 4 5 6 7 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/compositor/software_browser_compositor_output_surface.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/compositor/software_browser_compositor_output_surface.cc View 1 2 3 4 1 chunk +8 lines, -0 lines 0 comments Download
M content/browser/compositor/software_output_device_ozone.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/compositor/software_output_device_win.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 2 3 4 5 6 7 8 1 chunk +8 lines, -0 lines 0 comments Download
M content/renderer/android/synchronous_compositor_frame_sink.cc View 1 2 3 4 2 chunks +2 lines, -4 lines 0 comments Download
M services/ui/surfaces/direct_output_surface.h View 1 chunk +4 lines, -0 lines 0 comments Download
M services/ui/surfaces/direct_output_surface.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M services/ui/surfaces/direct_output_surface_ozone.h View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M services/ui/surfaces/direct_output_surface_ozone.cc View 1 2 3 4 5 6 7 8 9 2 chunks +16 lines, -14 lines 0 comments Download
M ui/compositor/test/in_process_context_factory.cc View 1 chunk +9 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 61 (49 generated)
danakj
enne: PTAL at everything boliu: webview and content owners fsamuel: services owners
4 years, 2 months ago (2016-10-07 01:38:22 UTC) #6
boliu
lgtm
4 years, 2 months ago (2016-10-07 02:39:13 UTC) #9
enne (OOO)
lgtm
4 years, 2 months ago (2016-10-08 00:20:55 UTC) #41
Fady Samuel
lgtm
4 years, 2 months ago (2016-10-08 00:21:31 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399983003/180001
4 years, 2 months ago (2016-10-08 01:02:40 UTC) #47
danakj
Oh +nyquist@chromium.org for blimp/
4 years, 2 months ago (2016-10-08 01:02:52 UTC) #49
danakj
On 2016/10/08 01:02:52, danakj wrote: > Oh mailto:+nyquist@chromium.org for blimp/ Who is OOO. So +dtrainor.
4 years, 2 months ago (2016-10-08 01:03:31 UTC) #51
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/277027)
4 years, 2 months ago (2016-10-08 01:13:46 UTC) #53
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2399983003/180001
4 years, 2 months ago (2016-10-10 20:53:43 UTC) #56
David Trainor- moved to gerrit
blimp/ lgtm sorry for the delay :(
4 years, 2 months ago (2016-10-10 20:57:57 UTC) #57
commit-bot: I haz the power
Committed patchset #10 (id:180001)
4 years, 2 months ago (2016-10-10 21:47:56 UTC) #59
commit-bot: I haz the power
4 years, 2 months ago (2016-10-10 21:49:22 UTC) #61
Message was sent while issue was closed.
Patchset 10 (id:??) landed as
https://crrev.com/70ffc43ceda0ffba0edf7ea136567af5bed5c819
Cr-Commit-Position: refs/heads/master@{#424255}

Powered by Google App Engine
This is Rietveld 408576698